Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Layout Adjustments #294

Merged
merged 11 commits into from
Oct 31, 2019
Merged

[Chore] Layout Adjustments #294

merged 11 commits into from
Oct 31, 2019

Conversation

grahamhency
Copy link
Contributor

@grahamhency grahamhency commented Oct 31, 2019 •
edited
Loading

Problem

UX identified quite a few smaller items that do not match their designs.

Solution

Fixed all the things.

Outline of items addressed:

  • Change header box-shadow to "Large Shadow"
  • Search bar should not move when collapsed
  • Branded background on collapse should only be applied to menu icon and not logo
  • Ability to specify light/dark icon color (this should override accessibility check)
  • Menu icon should not be a circle on hover
  • Menu icon should be 50% opacity on hover
  • Side nav menu icons should not move vertically when collapsed
  • Side nav with external links when collapsed have overflow problem
  • Side nav links that are too large expand multiple lines (UX)
  • Side nav active indicator should only be positioned on root level items, even for groups
  • Search should not scale and lose border when active

@grahamhency grahamhency added this to the v1.3.0 milestone Oct 31, 2019
@eligolding
Copy link
Contributor

image

StevenUlmer
StevenUlmer approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@StevenUlmer StevenUlmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple questions. Overall looks pretty good

projects/go-lib/src/lib/components/go-side-nav/go-nav-group/go-nav-group.component.html Outdated Show resolved Hide resolved
projects/go-lib/src/lib/components/go-side-nav/go-side-nav/go-side-nav.component.ts Show resolved Hide resolved
projects/go-lib/src/lib/components/go-side-nav/go-side-nav/go-side-nav.service.ts Outdated Show resolved Hide resolved
projects/go-lib/src/lib/go-config.service.ts Show resolved Hide resolved
@grahamhency grahamhency merged commit dced280 into v1.3.0 Oct 31, 2019
@grahamhency grahamhency deleted the chore_layout_adjustments branch October 31, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenUlmer StevenUlmer StevenUlmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@grahamhency @eligolding @StevenUlmer