Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading input to go-select #258

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Add loading input to go-select #258

merged 1 commit into from
Oct 9, 2019

Conversation

jaredami
Copy link
Contributor

@jaredami jaredami commented Oct 8, 2019

closes #255

This adds a loading input to our go-select so that we can take advantage of ng-select's loading spinner. This will allow us to indicate when the items which will populate a go-select dropdown are in the process of being retrieved.

@jaredami jaredami requested a review from grahamhency October 8, 2019 20:31
@jaredami jaredami added the chore General chore or maintenance task label Oct 8, 2019
grahamhency
grahamhency approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@grahamhency grahamhency added this to the v1.3.0 milestone Oct 9, 2019
@jaredami jaredami merged commit 5465eea into v1.3.0 Oct 9, 2019
@jaredami jaredami deleted the chore_add_loading_input_to_go_select branch October 9, 2019 13:52
@grahamhency grahamhency mentioned this pull request Oct 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamhency grahamhency grahamhency approved these changes

Assignees

@grahamhency grahamhency

Labels
chore General chore or maintenance task
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredami @grahamhency