Update box-shadows #261
Merged
Update box-shadows #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grahamhency - I've updated the variable names per Kim's suggestions. PR is ready for review. |
patrick-lewandowski
changed the title
grahamhency
reviewed
Oct 15, 2019
|
@patryk0605 to not hold up this PR any further, let's keep the search component using the old box-shadow as it provides better separation with its background. We can follow up with UX and determine if we need to update the shadow in a future release. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need this?
This PR is required to address the box shadow requirements specified within the DSM
How does this solve that?
Uses defined box-shadows.
Additional Info
Closes #197