Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Update Box Shadows #197

Closed
9 tasks
grahamhency opened this issue Sep 22, 2019 · 3 comments
Closed
9 tasks

[Chore] Update Box Shadows #197

grahamhency opened this issue Sep 22, 2019 · 3 comments
Assignees
@patrick-lewandowski
Labels
chore General chore or maintenance task in progress Work on this issue is in progress
Milestone
v1.3.0

Comments

@grahamhency
Copy link
Contributor

grahamhency commented Sep 22, 2019 •
edited
Loading

What general chore or task would you like to see performed?

Box shadows need to be updated to reflect design spec.
https://tangoe.invisionapp.com/dsm/tangoe/tangoe-ds/folder/components/5d7a967497799142a093ebd2

Are there any specific steps you would like completed?

  • Update and add new SCSS variables
    • Update $global-box-shadow to the "Normal Box Shadow" in the DSM
    • Add variable for "High Box Shadow"
    • Add variable for "Search Box Shadow"
    • Add variable for "Shell Dropdown Box Shadow"
  • Update components using current shadow that should be using alternate shadow.
    • go-action-sheet should use the "Shell Dropdown Box Shadow"
    • go-search should use the "Search Box Shadow"
    • go-header should use the "High Box Shadow"
@grahamhency grahamhency added chore General chore or maintenance task new issue This issue has yet to receive attention on hold This issue has prerequisites labels Sep 22, 2019
@grahamhency grahamhency modified the milestones: v1.2.1, v1.3.0 Sep 22, 2019
@grahamhency
Copy link
Contributor Author

Waiting on UX sync for clarification on usage of shadows, which components get which shadows

@grahamhency grahamhency removed the on hold This issue has prerequisites label Oct 4, 2019
@grahamhency
Copy link
Contributor Author

This task has all of the requirements. We're good to go here.

@patrick-lewandowski
Copy link
Contributor

I can take this issue

@grahamhency grahamhency added in progress Work on this issue is in progress and removed new issue This issue has yet to receive attention labels Oct 8, 2019
@patrick-lewandowski patrick-lewandowski mentioned this issue Oct 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrick-lewandowski patrick-lewandowski

Labels
chore General chore or maintenance task in progress Work on this issue is in progress
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
2 participants
@patrick-lewandowski @grahamhency