-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add appendTo input to go-select #260
Conversation
0c87706
to
cfd44d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaredami just a comment on this one, looks pretty good so far.
@jaredami Sorry for commenting on something so old, but just wanted to bring up that this solution introduces other issues. I am experiencing both of these issues that others have had with ng-select: ng-select/ng-select#1130 and ng-select/ng-select#929. The real solution will need to involve fixing the modal not to close, which @patryk0605 may have fixed here: #410 |
@eligolding Gotcha. Thanks for filling me in 👍 |
Hi, i continue to have the same problem. If I insert the component in a simple html page no problem, but if I insert it in a more complex context, the problem remains ... |
Closes #246
Currently, making a selection on a
go-select
within ago-modal
causes the modal to close. Sometimes we might desire that thego-modal
remain open until a submission button is clicked, for instance.By adding an
appendTo
input to ourgo-select
and passing it to theappendTo
input of the containedng-select
, we can make it so that ago-modal
will remain open upon making a selection to ago-select
within it usingappendTo="'body'"
.Example: