BUG: fix go-select dropdowns being cut off in go-accordian-panels #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredami
changed the title
grahamhency
approved these changes
Oct 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143
This PR addresses an issue in which GoSelect dropdowns are getting cutoff when their content expands below the bottom edge of a GoAccordionPanel. This was being caused by an
overflow: hiddenon the.go-accordion-panelcss class. We can change this tooverflow: visible, thus enabling the dropdown content to no longer get cut off, while also modifying the animation which occurs on expansion and collapse of a GoAccordionPanel to achieve the same effect as was provided byoverflow: hiddenpreviously.