Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Go Accordion overflow #143

Closed
akfernun opened this issue Aug 27, 2019 · 2 comments
Closed

[BUG] Go Accordion overflow #143

akfernun opened this issue Aug 27, 2019 · 2 comments
Assignees
Labels
bug Something isn't working in progress Work on this issue is in progress
Milestone

Comments

@akfernun
Copy link
Contributor

Describe the bug
In the GoAccordion component, there is a class (.go-accordion-panel__content-container) that has the overflow set to hidden. While I'm sure there are instances in which this makes sense, we're running into issues when implementing it in our reporting filters because it is hiding content from drop-downs.

Expected behavior
Remove the overflow so that content from the drop-down will be shown.

Screenshots

####Currently
Screen Shot 2019-08-27 at 11 49 57 AM

Desired effect

Screen Shot 2019-08-27 at 11 49 40 AM

@akfernun akfernun added the bug Something isn't working label Aug 27, 2019
@AlexOverbeck
Copy link
Contributor

AlexOverbeck commented Aug 27, 2019

@akfernun it looks like you are using ng-select. You should be able to fix this issue by setting the appendTo option in the configuration for that plugin to be something like 'body'.

That being said, we will look into ways we might be able to account for this on our end as well.

Read more here:
https://ng-select.github.io/ng-select#/append-to-element

@grahamhency grahamhency added this to the Needs Triaged milestone Sep 13, 2019
@grahamhency
Copy link
Contributor

@akfernun can you try what @AlexOverbeck said and see if that fixes your issue? Ideally, we don't want things showing up outside of the accordion expect when it's an overlay.

@grahamhency grahamhency modified the milestones: Needs Triaged, v1.3.0 Oct 4, 2019
@jaredami jaredami self-assigned this Oct 4, 2019
@jaredami jaredami added the in progress Work on this issue is in progress label Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress Work on this issue is in progress
Projects
None yet
Development

No branches or pull requests

4 participants