Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We have button variants for:
positive
negative
neutral
Issue Number: Closes #170
What is the new behavior?
We have button variants for:
secondary
tertiary
neutral
negative
Does this PR introduce a breaking change?
There are two changes that could be considered "breaking".
alert
variant is being removed. This was already deprecated in a previous version, but is officially being removed now.alert
that remain should be changed tonegative
positive
variant is being removed, however, we are going to accept it as a variant and change it toprimary
for now. In this case, it's not functionality breaking, but possibly UX breaking.positive
buttons will need to beprimary
. In that case, the buttons labeled aspositive
should be evaluated on a per-component basis to determine if they need to beprimary
or instead should besecondary
ortertiary
.Other information