Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Button Design Update #271

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Conversation

grahamhency
Copy link
Contributor

@grahamhency grahamhency commented Oct 14, 2019

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

We have button variants for:

  • positive
  • negative
  • neutral

Issue Number: Closes #170

What is the new behavior?

We have button variants for:

  • primary (replacing positive)
  • secondary
  • tertiary
  • neutral
  • negative

Does this PR introduce a breaking change?

  • Yes
  • No

There are two changes that could be considered "breaking".

  1. The alert variant is being removed. This was already deprecated in a previous version, but is officially being removed now.
  • Any instances of alert that remain should be changed to negative
  1. The positive variant is being removed, however, we are going to accept it as a variant and change it to primary for now. In this case, it's not functionality breaking, but possibly UX breaking.
  • Not all positive buttons will need to be primary. In that case, the buttons labeled as positive should be evaluated on a per-component basis to determine if they need to be primary or instead should be secondary or tertiary.

Other information

@grahamhency grahamhency added the chore General chore or maintenance task label Oct 14, 2019
@grahamhency grahamhency added this to the v1.3.0 milestone Oct 14, 2019
@grahamhency grahamhency requested a review from mwagz October 14, 2019 13:04
@grahamhency grahamhency force-pushed the chore_button_design_update branch from 5b917da to 5311c62 Compare October 14, 2019 15:31
@grahamhency grahamhency force-pushed the chore_button_design_update branch from 5311c62 to a34187f Compare October 14, 2019 15:34
@grahamhency grahamhency merged commit 9594b40 into v1.3.0 Oct 14, 2019
@grahamhency grahamhency deleted the chore_button_design_update branch October 14, 2019 16:25
@grahamhency grahamhency mentioned this pull request Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore General chore or maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants