Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Switch Toggle Documentation #278

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Conversation

grahamhency
Copy link
Contributor

Problem

We did not have documentation for the switch toggle component.

Solution

Added documentation for the switch toggle component.

Closes #223

@grahamhency grahamhency added the documentation Style Guide needs updated label Oct 15, 2019
@grahamhency grahamhency added this to the v1.3.0 milestone Oct 15, 2019
@grahamhency grahamhency requested a review from jaredami October 15, 2019 13:11
@grahamhency grahamhency changed the base branch from master to v1.3.0 October 15, 2019 13:11
@grahamhency grahamhency force-pushed the chore_switch_toggle_docs branch from 8e633d1 to 8313b10 Compare October 15, 2019 13:14
Copy link
Contributor

@jaredami jaredami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw an apparent typo and had one other question. Looks good!

@grahamhency grahamhency force-pushed the chore_switch_toggle_docs branch from 8313b10 to b49cfb4 Compare October 16, 2019 14:29
@grahamhency
Copy link
Contributor Author

@jaredami fixed those issues, ready for review.

@grahamhency grahamhency requested a review from jaredami October 16, 2019 14:29
Copy link
Contributor

@jaredami jaredami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@grahamhency grahamhency merged commit ca37f7a into v1.3.0 Oct 16, 2019
@grahamhency grahamhency deleted the chore_switch_toggle_docs branch October 16, 2019 19:24
@grahamhency grahamhency mentioned this pull request Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Style Guide needs updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants