Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch toggle label position #243

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Switch toggle label position #243

merged 1 commit into from
Oct 11, 2019

Conversation

eligolding
Copy link
Contributor

fixes #233

Following material's slide-toggle, I named the binding labelPosition and set the options as before and after.

@grahamhency grahamhency added the chore General chore or maintenance task label Oct 8, 2019
@grahamhency grahamhency added this to the v1.3.0 milestone Oct 8, 2019
StevenUlmer
StevenUlmer suggested changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@StevenUlmer StevenUlmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code for this looks good. This will need to be rebased from v1.3.0 tho before it can be merged.

@eligolding
Copy link
Contributor Author

@StevenUlmer done.

grahamhency
grahamhency approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, thanks @eligolding

@grahamhency grahamhency merged commit 9194625 into mobi:v1.3.0 Oct 11, 2019
@grahamhency grahamhency mentioned this pull request Oct 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenUlmer StevenUlmer StevenUlmer requested changes

@grahamhency grahamhency grahamhency approved these changes

Assignees
No one assigned
Labels
chore General chore or maintenance task
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eligolding @grahamhency @StevenUlmer