Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trino 449 release notes #22195

Merged
merged 1 commit into from
May 31, 2024
Merged

Add Trino 449 release notes #22195

merged 1 commit into from
May 31, 2024

Conversation

colebow
Copy link
Member

@colebow colebow commented May 29, 2024

Description

Assemble the release notes for the upcoming Trino 449 release.

Verification for each pull request

Format: PR/issue number, ✅ / ❌ rn ✅ / ❌ docs
✅ rn - release note added and verified, or assessed to be not necessary, set to ❌ rn before completion
✅ docs - need for docs assessed and merged, or assessed to be not necessary, set to ❌ docs before completion

16 May 2024

17 May 2024

18 May 2024

19 May 2024

20 May 2024

21 May 2024

22 May 2024

23 May 2024

24 May 2024

25 May 2024

26 May 2024

27 May 2024

28 May 2024

29 May 2024

30 May 2024

31 May 2024

docs/src/main/sphinx/release/release-449.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-449.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-449.md Outdated Show resolved Hide resolved
@martint martint merged commit d0f7d00 into trinodb:master May 31, 2024
6 checks passed
@github-actions github-actions bot added this to the 449 milestone May 31, 2024
Comment on lines +6 to +7
* Fix rare query failure or incorrect results for array types when the data is
dictionary encoded. ({issue}`21911`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How rare is the "rare"? What does it mean from user perspective?
Asking for guidance when formulating future proposed release notes entries.

* Improve performance of writing to Parquet files. ({issue}`22089`)
* Fix failure when filesystem caching is enabled on Trino clusters with a single
node. ({issue}`21987`)
* Fix failure when listing Hive tables with unsupported syntax. ({issue}`21981`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether "syntax" here is right. Maybe "serde" or "storage format"?

`hive.metastore.thrift.catalog-name` configuration property. (`10287`)
* Add support for configuring the query retry policy on the S3 filesystem with
the `s3.retry-mode` and `s3.max-error-retries` configuration properties.
* Improve performance of writing to Parquet files. ({issue}`22089`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Delta data files are Parquet, so maybe we should just say "Improve writing performance".

[equality delete](https://iceberg.apache.org/spec/#equality-delete-files)
files are used. ({issue}`18396`)
* Improve performance of writing to Parquet files. ({issue}`22089`)
* Fix failure when writing to tables with Iceberg `VARBINARY` values. ({issue}`22072`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this fixed writes to tables partitioned on varbinary column, not just tables with varbinary column


## Snowflake connector

* Fix incorrect type mapping for numeric values. ({issue}`20977`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be {{breaking}}?

cc @ebyhr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think so from what I can tell following along on the PR, but @ebyhr should confirm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we wanted initial snowflake PR to have as little type mapping as possible, because fixing it later is a breaking change (results are different). or was it not a correctness fix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was just narrowing down to smaller types on the snowflake side .. @lxynov and @ebyhr should confirm

@mosabua
Copy link
Member

mosabua commented Jun 3, 2024

@colebow can you send a PR to address the various feedback

Copy link
Member

@oneonestar oneonestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* Add support for configuring the query retry policy on the S3 filesystem with
  the `s3.retry-mode` and `s3.max-error-retries` configuration properties.

missing a link to issue.

## Hive connector

* Add support for specifying a catalog name in the Thrift metastore with the
`hive.metastore.thrift.catalog-name` configuration property. (`10287`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- `hive.metastore.thrift.catalog-name` configuration property. (`10287`)
+ `hive.metastore.thrift.catalog-name` configuration property. ({issue}`10287`)

@mosabua
Copy link
Member

mosabua commented Jun 4, 2024

A follow up PR - #22262

@colebow colebow deleted the colebow/rn-449 branch July 22, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

8 participants