Avoid flakiness in test when dropping potentially inexistent table #22109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
May 24, 2024
ebyhr
reviewed
May 24, 2024
| @@ -831,7 +831,7 @@ private void runTestCases(String tableName, List<TestCase> testCases) | |||
| .collect(joining("), (", "VALUES (", ")"))); | |||
| } | |||
| finally { | |||
| getTrinoExecutor().execute("DROP TABLE " + tableName); | |||
| getTrinoExecutor().execute("DROP TABLE IF EXISTS " + tableName); | |||
There was a problem hiding this comment.
The table should always exist when reaching this line. Adding IF EXISTS option doesn't make sense for me. Please add the rationale to PR description and commit body.
There was a problem hiding this comment.
Executor from getTrinoExecutor() (although it has nothing to do with concurrency) mislead me about concurrency.
You are right @ebyhr - the change is quite likely irrelevant.
There was a problem hiding this comment.
but it's not harmful either
There was a problem hiding this comment.
this is a wrong change. If CREATE TABLE succeeded, then we know that the table exists.
Why did we merge this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.