Correct numeric type mapping of Snowflake Connector #21755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-with-secrets sha=71772a083bde0174b2977a996b45ef4d233327cf |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/8887484201 |
|
Please check CI failure: https://github.com/trinodb/trino/actions/runs/8887484201/job/24402865556 |
|
@ebyhr Updated. |
|
/test-with-secrets sha=410c334554932a7b1a9a071a0c69115727495123 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8902552225 |
ebyhr
reviewed
May 15, 2024
plugin/trino-snowflake/src/test/java/io/trino/plugin/snowflake/TestSnowflakeConnectorTest.java
Show resolved
Hide resolved
plugin/trino-snowflake/src/test/java/io/trino/plugin/snowflake/TestingSnowflakeServer.java
Outdated
Show resolved
Hide resolved
| | `timestampntz` | `timestamp` | | ||
|
|
||
| Complete list of [Snowflake data types](https://docs.snowflake.com/en/sql-reference/intro-summary-data-types.html). | ||
| Because Trino and Snowflake each support types that the other does not, this |
For fixed-point numbers: - All fixed-point numeric types are decimals (NUMBER in Snowflake). - INT , INTEGER , BIGINT , SMALLINT , TINYINT , BYTEINT are synonymous with NUMBER(38, 0). For floating-point numbers: - FLOAT, FLOAT4, FLOAT8, DOUBLE, DOUBLE PRECISION, REAL are synonymous with each other. They're all 64-bit floating-point numbers.
|
Thanks @ebyhr . Comments addressed. |
ebyhr
approved these changes
May 17, 2024
|
Nice! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Final part of #21012. Fixing #20977.
Without this commit, Snowflake session property
JDBC_TREAT_DECIMAL_AS_INTis set to default value, which isTRUE. This will cause a problem when decimal values exceedLong.MAX_VALUE.Reference: https://docs.snowflake.com/en/sql-reference/data-types-numeric, https://docs.snowflake.com/en/sql-reference/parameters#jdbc-treat-decimal-as-int
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: