Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable JMX metrics for resource groups by default" #22185

Merged
merged 1 commit into from
May 30, 2024

Conversation

hashhar
Copy link
Member

@hashhar hashhar commented May 29, 2024

Description

This reverts commit 74e3ffa.

After this change JMX metrics for resource groups were not exported at all.

Additional context and related issues

Fixes #21343

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# General
* Fix exporting JMX metrics for resource groups. ({issue}`21343`)

This reverts commit 74e3ffa.

After this change JMX metrics for resource groups were not exported at
all.
@cla-bot cla-bot bot added the cla-signed label May 29, 2024
@github-actions github-actions bot added the docs label May 29, 2024
@hashhar hashhar requested review from wendigo and ebyhr May 29, 2024 09:57
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it difficult to resolve the issue without reverting?

@hashhar
Copy link
Member Author

hashhar commented May 30, 2024

Is it difficult to resolve the issue without reverting?

Maybe not, but it was not apparent to me how to solve it.
I'll merge this for now.

@hashhar hashhar merged commit 97b054e into trinodb:master May 30, 2024
97 checks passed
@hashhar hashhar deleted the hashhar/revert-jmx-export branch May 30, 2024 07:50
@github-actions github-actions bot added this to the 449 milestone May 30, 2024
@xkrogen
Copy link
Member

xkrogen commented Aug 6, 2024

Hey @hashhar just curious are you planning on re-submitting the change from #20810 to enable by default? (Assuming we fix the issue, of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Resource group metrics are not exported via JMX since 440
4 participants