Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert query runner to builder in ClickHouse #22154

Merged
merged 1 commit into from
May 27, 2024

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented May 27, 2024

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label May 27, 2024
@ebyhr ebyhr force-pushed the ebi/clickhouse-runner branch from 8bdca3d to f0a94b3 Compare May 27, 2024 08:30
@ebyhr ebyhr changed the title Convert query runner to record in ClickHouse Convert query runner to builder in ClickHouse May 27, 2024
@findepi
Copy link
Member

findepi commented May 27, 2024

Convert query runner to record in ClickHouse

IMO records are suitable for value objects (data carriers). I wouldn't use them for actors / active components, even though this is technically possible in Java. 

Thanks for backing this out.

@ebyhr
Copy link
Member Author

ebyhr commented May 27, 2024

It was a typo of the commit message. I didn't try a record in this PR :)

@ebyhr ebyhr merged commit 569b045 into trinodb:master May 27, 2024
18 checks passed
@ebyhr ebyhr deleted the ebi/clickhouse-runner branch May 27, 2024 21:06
@github-actions github-actions bot added this to the 449 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants