Do not slice ListVector #22041
Merged
Do not slice ListVector #22041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/do-not-transfer-v2
branch
from
b1f45be to
d35d036
Compare
|
I don't know why are we copying memory in the first place to just read a vector. |
Probably for explicit ownership of the underlying buffers otherwise maybe the contents change between when it's sent back vs when it's actually read? |
|
@hashhar this is read only memory. I don't think this is the reason |
|
And we seems to do it only for lists, but not for other types and it doesn't make sense because they are encoded in the similiar way |
|
I think that we were using much more memory than needed |
ebyhr
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: