-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable warning/error logs from libraries in tests #22186
Enable warning/error logs from libraries in tests #22186
Conversation
I can't say that for sure for libraries we currently use in this project, but that's certainly my past experience. |
a923d29
to
5b90fa7
Compare
Warning and errors are rarely seen by engineers, but still it's better not to hide them, they may (now or in the future) contain some actionable information. When a library over-verbosely logs some warnings/errors, let's suppress these selectively.
5b90fa7
to
5e5b9c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Libraries should not be reporting problems via logging. If there’s an actionable error, they should fail with an exception.
These logs were turned off intentionally, precisely because they were generating noise in the CI logs that’s not actionable and just makes it harder to spot real problems such as test failures.
I tend to agree. But I do not get to choose what libraries do and I have been burned in the past by ignoring warnings from a library. This was so important that I even had a test framework to watch out for new warning/errors and it turned helpful in future situations. Agreeing that we may need to suppress certain overly verbose loggers. For example Iceberg library is a known offender and logs A LOT at INFO level. So if they also log a lot at warn/error level then either we help them fix this, or suppress such a misbehaving library. |
@martint can you comment on the intention of turning off WARN/ERROR? I get why we do not want to have flooding of INFO logs from external libs but seeing errors in logs can point us to problems in our code. Even if not in an optimal way - it is good nonetheless. I think this change is good and should have not been reverted. |
Example useful warning logged by Iceberg library
i noticed this in some other application using Iceberg library. Wonder whether something like this gets logged when Trino uses Iceberg library. |
Warning and errors are rarely seen by engineers, but still it's better not to hide them, they may (now or in the future) contain some actionable information. When a library over-verbosely logs some warnings/errors, let's suppress these selectively.
Follows #19676