Enable varchar equality predicate pushdown for ClickHouse connector #21557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
sylph-eu
force-pushed
the
clickhouse_connector_2
branch
from
3317f10 to
b28c04b
Compare
sylph-eu
force-pushed
the
clickhouse_connector_2
branch
from
b28c04b to
16cfe11
Compare
|
Rebased. |
ebyhr
reviewed
Apr 22, 2024
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/BaseClickHouseTypeMapping.java
Outdated
Show resolved
Hide resolved
sylph-eu
force-pushed
the
clickhouse_connector_2
branch
2 times, most recently
from
48d7cd9 to
72ce208
Compare
ebyhr
reviewed
Apr 29, 2024
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/BaseClickHouseTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/BaseClickHouseTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/BaseClickHouseTypeMapping.java
Show resolved
Hide resolved
sylph-eu
force-pushed
the
clickhouse_connector_2
branch
2 times, most recently
from
4681ef7 to
c15a930
Compare
sylph-eu
force-pushed
the
clickhouse_connector_2
branch
from
c15a930 to
36db7fa
Compare
|
Rebased |
|
Hi @sylph-eu when are we planning to release this PR? Trino version. |
sylph-eu
force-pushed
the
clickhouse_connector_2
branch
from
36db7fa to
2ac3862
Compare
|
Rebased once more. |
|
Hello @ebyhr, this is very good feature and our team is eagerly waiting for it. It will be really good if you can check. |
ebyhr
reviewed
May 17, 2024
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/BaseClickHouseTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/BaseClickHouseTypeMapping.java
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/BaseClickHouseTypeMapping.java
Show resolved
Hide resolved
sylph-eu
force-pushed
the
clickhouse_connector_2
branch
2 times, most recently
from
65c976a to
105ef68
Compare
ebyhr
force-pushed
the
clickhouse_connector_2
branch
from
105ef68 to
cc8cea6
Compare
2 tasks
ebyhr
force-pushed
the
clickhouse_connector_2
branch
from
cc8cea6 to
ba35000
Compare
ebyhr
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR depends partially addresses #7100 (only textual types for now).
Type mapping unit tests were extended with more cases. In addition to
TypeandNullable(Type)I'm testing whetherLowCardinalitymodifier causes issues. In the past ClickHouse had some incompatibilities between regular and LowCardinality types, therefore it's worth putting them in the unit tests.Only equality predicate is enabled for now as ClickHouse does not support collation. Respective unit tests were put into
TestClickHouseConnectorTest.testTextualPredicatePushdown.Additional context and related issues
I hope to continue working on #7100 to support pushdown for more more types (enums, decimals, etc).
Release notes
(X) Release notes are required, with the following suggested text: