Enable enum equality predicate pushdown for ClickHouse connector #21585
Conversation
sylph-eu
force-pushed
the
clickhouse_connector_3
branch
from
7f3b9d7 to
88618fe
Compare
|
Rebased. |
| assertQuerySucceeds(format("SELECT value FROM %s WHERE value = 'hello'", table.getName())); | ||
|
|
||
| // ClickHouse shall fail when enum string is not exact | ||
| assertQueryFails(format("SELECT value FROM %s WHERE value = 'Hello'", table.getName()), ".*Unknown\\s+element.*\\n*.*"); |
There was a problem hiding this comment.
This query succeeded without this PR's change. I don't think users want to face the query failure.
There was a problem hiding this comment.
Yes, with equality pushdown the behavior changes.
I'm thinking of the following workaround to preserve backward compatibility: SELECT value FROM %s WHERE toString(value) = 'Hello', note toString(value). Right now I'm looking at how I can rewrite expression to convert enum columns to string when it's necessary.
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Show resolved
Hide resolved
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
sylph-eu
force-pushed
the
clickhouse_connector_3
branch
from
88618fe to
2592308
Compare
sylph-eu
force-pushed
the
clickhouse_connector_3
branch
from
2592308 to
44e0fcb
Compare
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
|
Feel free to reopen and rebase or start a new PR if you want to continue working on this PR @sylph-eu |
Description
Partially addresses #7100 .
Enables equality predicate pushdown for enum types. It's similar to VARCHAR (from Trino's perspective), but is not that "general-purpose". Until ClickHouse fully supports collation (atm it's only implemented for ORDER BY clause) range predicates are not pushed down.
Additional context and related issues
Submitted ClickHouse/ClickHouse#62701 for unexpected behaviour.
Next I'll be looking at Decimals, time types and aggregate functions.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X ) Release notes are required, with the following suggested text: