Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy non-gRPC client from Pinot #22213

Merged
merged 1 commit into from
May 31, 2024
Merged

Remove legacy non-gRPC client from Pinot #22213

merged 1 commit into from
May 31, 2024

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented May 31, 2024 •
edited
Loading

Description

gRPC has been enabled since 2022 June.

Release notes

(x) Release notes are required, with the following suggested text:

# Pinot
* Remove support for non-gRPC client, along with `pinot.grpc.enabled` and
  `pinot.estimated-size-in-bytes-for-non-numeric-column` config properties. ({issue}`22213`)

@cla-bot cla-bot bot added the cla-signed label May 31, 2024
@github-actions github-actions bot added the docs label May 31, 2024
@ebyhr ebyhr force-pushed the ebi/pinot-remove-non-grpc branch from 9ea8dd4 to 9d543ec Compare May 31, 2024 08:42
@ebyhr ebyhr requested review from wendigo, elonazoulay and hashhar May 31, 2024 09:08
@ebyhr ebyhr force-pushed the ebi/pinot-remove-non-grpc branch from 9d543ec to 63d9ca8 Compare May 31, 2024 09:09
@wendigo
Copy link
Contributor

wendigo commented May 31, 2024

LGTM. We've discussed that with @elonazoulay some time ago

@ebyhr ebyhr merged commit bab146a into trinodb:master May 31, 2024
18 of 20 checks passed
@ebyhr ebyhr deleted the ebi/pinot-remove-non-grpc branch May 31, 2024 09:32
@github-actions github-actions bot added this to the 449 milestone May 31, 2024
@colebow colebow mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo approved these changes

@elonazoulay elonazoulay Awaiting requested review from elonazoulay

@hashhar hashhar Awaiting requested review from hashhar

Assignees
No one assigned
Labels
cla-signed docs
Milestone
449
Development

Successfully merging this pull request may close these issues.
2 participants
@ebyhr @wendigo