Fail when multiple JVM args matching #22160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
The `pattern` argument was not a pattern.
The JVM args verification would take first argument matching, silently ignoring any subsequent matching arguments. It's unclear whether first one or last one is effective (or something else), so it's better to bail out on multiple matches.
findepi
force-pushed
the
findepi/fail-when-multiple-jvm-args-matching-b27eaa
branch
from
d74ae4f to
0b1a7a5
Compare
losipiuk
approved these changes
May 27, 2024
wendigo
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JVM args verification would take first argument matching, silently ignoring any subsequent matching arguments. It's unclear whether first one or last one is effective (or something else), so it's better to bail out on multiple matches.