Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArrayType indeterminateOperator with a DictionaryBlock #22125

Merged
merged 1 commit into from
May 24, 2024

Conversation

dain
Copy link
Member

@dain dain commented May 24, 2024

Description

The indeterminate operator was not checking the correct number of indexes in the dictionary. This could result in out of bounds exception or in rare situations checking too few indexes resulting in an incorrect result.

Fixes #21911

Release notes

(x) Release notes are required, with the following suggested text:

# Section
* Fix rare out of bounds or incorrect result from indeterminate operator for array type when the data is dictionary encoded. ({issue}`21911`)

The indeterminate operator was not checking the correct number of
indexes in the dictionary. This could result in out of bounds exception
or in rare situations checking too few indexes resulting in an incorrect
result.
@dain dain requested a review from electrum May 24, 2024 22:46
@cla-bot cla-bot bot added the cla-signed label May 24, 2024
@dain dain merged commit 5afdfce into trinodb:master May 24, 2024
93 of 94 checks passed
@dain dain deleted the fix-array-type-indeterminate-operator branch May 24, 2024 23:48
@github-actions github-actions bot added this to the 449 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Invalid position 2 in block with 2 positions with multiple filters on array(varchar)
3 participants