Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Pinot Libraries to 1.1.0 #21234

Merged
merged 1 commit into from
May 24, 2024
Merged

Upgrade Pinot Libraries to 1.1.0 #21234

merged 1 commit into from
May 24, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Mar 25, 2024 •
edited by ebyhr
Loading

Description

Fixes #19919

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@wendigo wendigo added the no-release-notes This pull request does not require release notes entry label Mar 25, 2024
@cla-bot cla-bot bot added the cla-signed label Mar 25, 2024
@wendigo wendigo requested a review from elonazoulay March 25, 2024 12:51
@wendigo wendigo force-pushed the pinot-1.0.0 branch 3 times, most recently from 86424c5 to 104461a Compare March 25, 2024 14:56
@wendigo
Copy link
Contributor Author

wendigo commented Mar 25, 2024

@elonazoulay I've got it mostly working. Legacy (Non-grpc) is failing for 3 tests that I've disabled. Can you take a look?

@wendigo
Copy link
Contributor Author

wendigo commented Mar 25, 2024

[WARNING] Tests run: 534, Failures: 0, Errors: 0, Skipped: 176 🥳

@wendigo
Copy link
Contributor Author

wendigo commented Mar 25, 2024

@xiangfu0 unfortunately this change is not yet ready as I was forced to disable 3 failing tests that are returning incorrect results. Seems like a Pinot bug.

@xiangfu0
Copy link
Contributor

@xiangfu0 unfortunately this change is not yet ready as I was forced to disable 3 failing tests that are returning incorrect results. Seems like a Pinot bug.

Thanks, can you link the PRs here? I can help prioritize.

@wendigo
Copy link
Contributor Author

wendigo commented Mar 25, 2024

@xiangfu0 I don't have fix yet, disabled tests are here: https://github.com/trinodb/trino/pull/21234/files#diff-b1808e48847579e72593f11e3128e594b8bf799690a48c1f3bb3319aeffd5231R46

@ebyhr ebyhr mentioned this pull request Mar 26, 2024
Closed
@elonazoulay
Copy link
Member

@elonazoulay I've got it mostly working. Legacy (Non-grpc) is failing for 3 tests that I've disabled. Can you take a look?

Yessir!

@wendigo wendigo closed this Apr 23, 2024
@wendigo wendigo reopened this Apr 29, 2024
@github-actions GitHub Actions
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label May 21, 2024
@mosabua mosabua added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels May 21, 2024
@elonazoulay elonazoulay mentioned this pull request May 24, 2024
Closed
@github-actions github-actions bot added the docs label May 24, 2024
@wendigo wendigo requested review from ebyhr, elonazoulay and xiangfu0 May 24, 2024 07:10
@wendigo
Copy link
Contributor Author

wendigo commented May 24, 2024

Locally tests are passing:

[INFO] Results:
[INFO]
[WARNING] Tests run: 539, Failures: 0, Errors: 0, Skipped: 175
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:33 min
[INFO] Finished at: 2024-05-24T09:12:34+02:00
[INFO] ------------------------------------------------------------------------

Great work @elonazoulay 🎉 This is the last outdated Trino plugin.

ebyhr
ebyhr reviewed May 24, 2024
View reviewed changes
plugin/trino-pinot/pom.xml Outdated Show resolved Hide resolved
@wendigo wendigo requested a review from ebyhr May 24, 2024 08:35
ebyhr
ebyhr approved these changes May 24, 2024
View reviewed changes
plugin/trino-pinot/pom.xml
<dep.pinot.version>1.1.0</dep.pinot.version>
<!-- additional JVM flags required by chronicle-hft which is used by pinot-segment spi -->
<air.test.jvm.additional-arguments>${air.test.jvm.additional-arguments.default}
--add-opens=java.base/java.lang.reflect=ALL-UNNAMED</air.test.jvm.additional-arguments>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document this option in pinot.md. Follow-up is fine.

@wendigo wendigo merged commit 5251eb1 into master May 24, 2024
20 checks passed
@wendigo wendigo deleted the pinot-1.0.0 branch May 24, 2024 09:00
@github-actions github-actions bot added this to the 449 milestone May 24, 2024
@colebow colebow mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@elonazoulay elonazoulay elonazoulay approved these changes

@xiangfu0 xiangfu0 Awaiting requested review from xiangfu0

Assignees
No one assigned
Labels
cla-signed docs no-release-notes This pull request does not require release notes entry stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Milestone
449
Development

Successfully merging this pull request may close these issues.

Apache pinot connector 1.0.0 release
5 participants
@wendigo @xiangfu0 @elonazoulay @ebyhr @mosabua