Reuse temp variables in other code generators #22011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettyjamesm
force-pushed
the
reuse-more-variables
branch
2 times, most recently
from
6beba0f to
44238ca
Compare
dain
approved these changes
May 17, 2024
core/trino-main/src/main/java/io/trino/sql/gen/LambdaBytecodeGenerator.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/gen/LambdaBytecodeGenerator.java
Outdated
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
reuse-more-variables
branch
from
44238ca to
279d9d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates more code generators to use
Scope#getOrCreateTempVariableto increase variable reuse opportunities and reduce overall generated code size.Additional context and related issues
Follows up on work done in #22004 on
RowExpressionCodeGeneratorand enabled by airlift/bytecode#18Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: