Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent IntelliJ from failing to import Maven project #22029

Merged
merged 1 commit into from
May 20, 2024
Merged

Prevent IntelliJ from failing to import Maven project #22029

merged 1 commit into from
May 20, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented May 20, 2024

IntelliJ is using bundled JDK to invoke maven wrapper which will fail if JDK is lower than 22

@wendigo
Prevent IntelliJ from failing to import Maven project
b4f2aa8 
IntelliJ is using bundled JDK to invoke maven wrapper which will fail if JDK is lower than 22
@cla-bot cla-bot bot added the cla-signed label May 20, 2024
@wendigo wendigo requested review from findepi and losipiuk May 20, 2024 11:39
@wendigo
Copy link
Contributor Author

wendigo commented May 20, 2024

Screenshot 2024-05-20 at 13 43 26

It matters when Use settings from maven.config is checked. Despite the name - jvm.config is imported as well.

@wendigo wendigo merged commit fa27d05 into master May 20, 2024
99 of 102 checks passed
@wendigo wendigo deleted the serafin/prevent-intellij-from-failing branch May 20, 2024 12:22
@github-actions github-actions bot added this to the 449 milestone May 20, 2024
@findepi
Copy link
Member

findepi commented May 20, 2024

I had Use settings from maven.config set and didn't see intellij failing yet.
Did the problem depend on additional factors?

@wendigo
Copy link
Contributor Author

wendigo commented May 20, 2024

Yes. After IDE restart

@wendigo
Copy link
Contributor Author

wendigo commented May 21, 2024 •
edited
Loading

Screenshot 2024-05-21 at 20 11 52

@colebow colebow mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losipiuk losipiuk losipiuk approved these changes

@findepi findepi Awaiting requested review from findepi

Assignees
No one assigned
Labels
cla-signed
Milestone
449
Development

Successfully merging this pull request may close these issues.
3 participants
@wendigo @findepi @losipiuk