Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding and droping fields to records wrapped in array #22115

Merged
merged 3 commits into from
May 25, 2024

Conversation

losipiuk
Copy link
Member

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 24, 2024
@losipiuk losipiuk requested review from ebyhr and findepi May 24, 2024 13:55
@github-actions github-actions bot added the iceberg Iceberg connector label May 24, 2024
@losipiuk losipiuk force-pushed the lo/add-field-record-in-list branch from 4ecc7db to b0786b4 Compare May 24, 2024 14:39
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SET DATA TYPE also supports fields i believe, can you please update this one too.

cc @findinpath

@losipiuk losipiuk force-pushed the lo/add-field-record-in-list branch from b0786b4 to b88e5d9 Compare May 24, 2024 16:14
@losipiuk
Copy link
Member Author

SET DATA TYPE also supports fields i believe, can you please update this one too.

here you are. If you meant setting type for field

@losipiuk losipiuk force-pushed the lo/add-field-record-in-list branch from b88e5d9 to 64102fc Compare May 24, 2024 17:22
@losipiuk losipiuk force-pushed the lo/add-field-record-in-list branch from 64102fc to 0e01afd Compare May 24, 2024 17:23
@losipiuk losipiuk merged commit ef5489f into trinodb:master May 25, 2024
95 checks passed
@github-actions github-actions bot added this to the 449 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

2 participants