Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding and dropping fields to records wrapped in array #22232

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

losipiuk
Copy link
Member

@losipiuk losipiuk commented Jun 2, 2024

Description

Rework of #22115 following syntax guidelines from #16959

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Jun 2, 2024
@losipiuk losipiuk requested review from ebyhr, martint and findepi June 2, 2024 21:19
@github-actions github-actions bot added the iceberg Iceberg connector label Jun 2, 2024
@losipiuk losipiuk added syntax-needs-review and removed iceberg Iceberg connector labels Jun 2, 2024
@losipiuk
Copy link
Member Author

losipiuk commented Jun 2, 2024

@martint I added syntax-needs-review label - but I am not sure if needed given #16959 exists

@losipiuk losipiuk force-pushed the lo/add-nested-record-rework branch from b6c4b09 to 0547729 Compare June 3, 2024 08:34
@github-actions github-actions bot added the iceberg Iceberg connector label Jun 3, 2024
@losipiuk
Copy link
Member Author

losipiuk commented Jun 3, 2024

CI: #18697

@losipiuk losipiuk force-pushed the lo/add-nested-record-rework branch from 0547729 to 442866f Compare June 3, 2024 09:27
@mosabua mosabua changed the title Allow adding and droping fields to records wrapped in array Allow adding and dropping fields to records wrapped in array Jun 4, 2024
@losipiuk
Copy link
Member Author

@martint I added syntax-needs-review label - but I am not sure if needed given #16959 exists

ping @martint

@losipiuk
Copy link
Member Author

@martint I added syntax-needs-review label - but I am not sure if needed given #16959 exists

ping @martint

ping @martint

@losipiuk
Copy link
Member Author

@martint I added syntax-needs-review label - but I am not sure if needed given #16959 exists

ping @martint

ping @martint

friendly ping @martint. This is simple - would be nice to close

@losipiuk
Copy link
Member Author

Thanks @martint :)

@losipiuk losipiuk merged commit 4fe6086 into trinodb:master Jun 21, 2024
95 checks passed
@github-actions github-actions bot added this to the 451 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants