Allow filesystem caching on coordinator unconditionally

[raunaqmorarka]

Description

Earlier this was used to work around bugs which were encountered when filesystem caching was enabled on coordinator, it's not used for that anymore.
Removing this avoids confusion about caching not working on hive connector in a single node setup

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Hive
* Allow file system caching on coordinator. ({issue}`issuenumber`)

[osscm]

@raunaqmorarka not related to this PR.

I was thinking about one question, that user might want to configure cache with differently at coordinator vs worker.
we have this config available, will be applicable to coordinator and worker both.

https://trino.io/docs/current/object-storage/file-system-cache.html#configuration

Any thoughts?

[raunaqmorarka]

@raunaqmorarka not related to this PR.

I was thinking about one question, that user might want to configure cache with differently at coordinator vs worker. we have this config available, will be applicable to coordinator and worker both.

https://trino.io/docs/current/object-storage/file-system-cache.html#configuration

Any thoughts?

Could you elaborate what this difference in configuring caching on the coordinator vs worker would be and why ?

[findepi]

Earlier this was used to work around bugs which were encountered when filesystem caching was enabled on coordinator, it's not used for that anymore.

do you maybe remember what these were?

[raunaqmorarka]

Earlier this was used to work around bugs which were encountered when filesystem caching was enabled on coordinator, it's not used for that anymore.

do you maybe remember what these were?

I forget which one exactly, but there were issues initially when we tried to enabled caching on coordinator in delta and iceberg
91b22ca
#20696
There was also some ongoing discussion about what is safe to cache in delta lake metadata.
So we ended up enabling it coordinator in delta and iceberg in follow-ups as these were resolved and this mechanism was useful in doing that in steps. Now we no longer need it, and it causes some confusion to new users when filesystem caching doesn't work in single node setups in hive.

[findepi]

91b22ca
#20696

these do not look coordinator-related

[raunaqmorarka]

91b22ca
#20696

these do not look coordinator-related

I think the relation with coordinator was that only coordinator would load metadata files and that metadata would be non-orc/parquet formats which use streaming read APIs and the bugs were in those implementations.