Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw TrinoException in case of not found catalog #22070

Merged
merged 1 commit into from
May 22, 2024

Conversation

pajaks
Copy link
Member

@pajaks pajaks commented May 22, 2024

Description

In case not found catalog in catalog manager throw TrinoException with clear error type.

Additional context and related issues

Example stack trace:

 "type": "java.lang.IllegalArgumentException",
  "message": "No catalog 'test'",
  "suppressed": [],
  "stack": [
    "com.google.common.base.Preconditions.checkArgument(Preconditions.java:220)",
    "io.trino.connector.StaticCatalogManager.getConnectorServices(StaticCatalogManager.java:229)",
    "io.trino.connector.ConnectorCatalogServiceProvider.getService(ConnectorCatalogServiceProvider.java:40)",
    "io.trino.split.PageSourceManager.createPageSource(PageSourceManager.java:57)",

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 22, 2024
@pajaks pajaks requested review from wendigo and losipiuk May 22, 2024 13:04
@wendigo wendigo merged commit 316b29c into trinodb:master May 22, 2024
93 checks passed
@github-actions github-actions bot added this to the 449 milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants