Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MuseScore 3.5 Alpha PRs to be merged #5960

Closed
anatoly-os opened this issue Apr 16, 2020 · 35 comments
Closed

MuseScore 3.5 Alpha PRs to be merged #5960

anatoly-os opened this issue Apr 16, 2020 · 35 comments
Assignees
@anatoly-os
Milestone
MuseScore 3.5 Alpha

Comments

@anatoly-os
Copy link
Contributor

Leave a comment with the links to the PRs you think are worth merging to MuseScore 3.5 Alpha.
@anatoly-os anatoly-os added this to the MuseScore 3.5 milestone Apr 16, 2020
@anatoly-os anatoly-os self-assigned this Apr 16, 2020
@MarcSabatella
Copy link
Contributor

MarcSabatella commented Apr 16, 2020 •
edited by anatoly-os
Loading

The ones I have had my eye on are:

#5812
#5919
#5947 or #5728

As I look through the list, I see a whole bunch of others that I'd love to see even though I haven't really looked at them. See for instance:

#5886 and #5887
#5881 (this one can affect layout, though)
#5841 and #5834

@shoogle
Copy link
Contributor

shoogle commented Apr 17, 2020 •
edited by anatoly-os
Loading

#5890
#5959
#5962
#4757

@Spire42
Copy link
Contributor

Spire42 commented Apr 17, 2020 •
edited by anatoly-os
Loading

The following PR is an important one to merge for 3.5:

These two others aren't as important but are also useful small fixes that are both simple and safe to merge in:

@Harmoniker1
Copy link
Contributor

Harmoniker1 commented Apr 17, 2020 •
edited
Loading

I would say #5956, #5948, #5929, #5871, #5644, #5630.

And very important one: #5371! I think the "under discussion" label can be removed. Matt, Marc and I have all agreed to this change and so far no one has offered a considerable reason of opposing this change. This concerns a very important layout behaviour. I suppose I don't really have to say anything further. Just consider this, please.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 17, 2020 •
edited
Loading

My queued up ones:

Others:

@njvdberg
Copy link
Contributor

njvdberg commented Apr 17, 2020 •
edited by anatoly-os
Loading

#5918
#5876
#5796 (unless #5817 is used instead (preferably))
#5792
#5750
#5722
#5674
#5647

@blackears
Copy link
Contributor

blackears commented Apr 17, 2020 •
edited by anatoly-os
Loading

#5808
#5807
#5813
#5814

@SKefalidis
Copy link
Contributor

SKefalidis commented Apr 17, 2020 •
edited by anatoly-os
Loading

Since @MarcSabatella referenced some of my text editing related PRs I believe that the following are also nice improvements:
#5875
#5870
#5884 (if #5881 is merged, this one follows the same logic)

@ecstrema
Copy link
Contributor

ecstrema commented Apr 18, 2020 •
edited
Loading

#5854
#5646
#5628
These are not mine, but I would really like it if they could be part of 3.5
#5795
#5829
#5779

@ecstrema
Copy link
Contributor

ecstrema commented Apr 18, 2020 •
edited by anatoly-os
Loading

and mtest for msvc (#5954), since it might help with incoming bug fixes

@shoogle
Copy link
Contributor

shoogle commented Apr 19, 2020

#5760

@Harmoniker1
Copy link
Contributor

Harmoniker1 commented Apr 20, 2020 •
edited by anatoly-os
Loading

#5972

@anatoly-os anatoly-os linked a pull request Apr 21, 2020 that will close this issue
fix #303078: Fixed a bug where the cursor would be on the wrong height after deleting all chars in a line #5884
Merged
7 tasks
@anatoly-os anatoly-os removed a link to a pull request Apr 21, 2020
fix #303078: Fixed a bug where the cursor would be on the wrong height after deleting all chars in a line #5884
Merged
7 tasks
@jthistle
Copy link
Contributor

#5715 would be good, it doesn't affect anything else.

@anatoly-os
Copy link
Contributor Author

anatoly-os commented Apr 21, 2020 •
edited
Loading

Ok, 22 PRs left. If you want to suggest more PRs, please add them as a new comment, don't edit the existing ones.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 21, 2020 •
edited
Loading

@Philzen
Copy link

Philzen commented Apr 22, 2020 •
edited
Loading

@Harmoniker1
Copy link
Contributor

Harmoniker1 commented Apr 22, 2020 •
edited
Loading

@MarcSabatella
Copy link
Contributor

MarcSabatella commented Apr 22, 2020 •
edited by anatoly-os
Loading

Other than my pair of text style fixsd #5947 and #5728 (two different solutions to same problem) that are already listed, I have one other pending PR from a year ago, fixing a bug in transposition, I'd like to see added. I did rebase & update it recently and it does seem to work well.

@IsaacWeiss
Copy link
Contributor

IsaacWeiss commented Apr 24, 2020 •
edited by anatoly-os
Loading

#5560

@blackears
Copy link
Contributor

blackears commented Apr 24, 2020 •
edited by anatoly-os
Loading

#5985

@Harmoniker1
Copy link
Contributor

Harmoniker1 commented Apr 27, 2020 •
edited
Loading

#5996

@anatoly-os
Copy link
Contributor Author

anatoly-os commented Apr 28, 2020 •
edited
Loading

Ok, the remaining ones are:

@njvdberg
Copy link
Contributor

njvdberg commented Apr 28, 2020 •
edited
Loading

@SKefalidis
Copy link
Contributor

SKefalidis commented Apr 28, 2020 •
edited by anatoly-os
Loading

@blackears
Copy link
Contributor

blackears commented Apr 28, 2020 •
edited by anatoly-os
Loading

#5808

@shoogle
Copy link
Contributor

shoogle commented Apr 28, 2020 •
edited
Loading

@IsaacWeiss
Copy link
Contributor

IsaacWeiss commented Apr 29, 2020 •
edited by anatoly-os
Loading

@AntonioBL
Copy link
Contributor

AntonioBL commented Apr 29, 2020 •
edited by anatoly-os
Loading

If I am not too late:

@anatoly-os
Copy link
Contributor Author

No more pull requests with NEW functionality will be accepted.

@worldwideweary
Copy link
Contributor

worldwideweary commented Apr 29, 2020 •
edited
Loading

Regarding some of my older PRs from December 2019/Jan 2020:

PR #5564: Page width shortcut
PR #5637: Same Beat/Measure options in select all similar dialogue,
PR #5568: Update range transposition shortcut to selection only
PR #5620: Some Extra Navigation Shortcuts
PR #5577: Diatonic transpose shortcuts which keep degree alterations.
PR #5623: Extra default zoom preferences

If there is any possibility for added functionality before 3.5 is released, some of these would be nice to get slipped in

P.S. Looking forward to seeing how the 3.5 experience is.

@shoogle
Copy link
Contributor

shoogle commented Apr 29, 2020 •
edited by anatoly-os
Loading

@Harmoniker1
Copy link
Contributor

Harmoniker1 commented Apr 30, 2020 •
edited by anatoly-os
Loading

#6016 (reverts #5380)

@Spire42
Copy link
Contributor

Spire42 commented Apr 30, 2020 •
edited by anatoly-os
Loading

@blackears
Copy link
Contributor

blackears commented May 1, 2020 •
edited by anatoly-os
Loading

#6014 This fixes a translation issue.

@anatoly-os
Copy link
Contributor Author

anatoly-os commented May 3, 2020 •
edited
Loading

3.5alpha branch has been created. See #6027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anatoly-os anatoly-os

Labels
None yet
Projects
None yet
Milestone
MuseScore 3.5 Alpha
Development

No branches or pull requests