fix #278988 Copy and paste notes in Piano Roll Editor #5808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harmoniker1
reviewed
Mar 13, 2020
blackears
force-pushed
the
278988-paste-non-contigious-notes-in-PRE-2
branch
2 times, most recently
from
e534f12 to
b6ab1d8
Compare
blackears
force-pushed
the
278988-paste-non-contigious-notes-in-PRE-2
branch
from
b6ab1d8 to
f786de5
Compare
dmitrio95
reviewed
Mar 19, 2020
blackears
force-pushed
the
278988-paste-non-contigious-notes-in-PRE-2
branch
from
f786de5 to
08857b7
Compare
blackears
force-pushed
the
278988-paste-non-contigious-notes-in-PRE-2
branch
2 times, most recently
from
46f5c70 to
cca23aa
Compare
|
Rebase needed. |
blackears
force-pushed
the
278988-paste-non-contigious-notes-in-PRE-2
branch
3 times, most recently
from
1cab9bc to
2926374
Compare
|
@blackears rebase and addressing the review are needed |
blackears
force-pushed
the
278988-paste-non-contigious-notes-in-PRE-2
branch
2 times, most recently
from
1213bb0 to
93b186e
Compare
|
@blackears rebase is needed after merging your other PR, sorry :( |
blackears
force-pushed
the
278988-paste-non-contigious-notes-in-PRE-2
branch
2 times, most recently
from
ec0bd9c to
8c475f5
Compare
blackears
force-pushed
the
278988-paste-non-contigious-notes-in-PRE-2
branch
from
8c475f5 to
2a93351
Compare
anatoly-os
added
work in progress
Can now copy and paste notes in piano roll editor using the right click menu. Allowing cut and paste of nodes in piano roll editor. Allowing cut and paste of nodes in piano roll editor. Cleaning code. Using Fraction::fromTicks to convert ticks. Changing variable names. Updating cut/paste to use Fraction Adding cut shortcut. Undo now reverts all notes from paste. Cleaning up code Refactoring method Fixing rebase Making PRE child of main window. Can now drag notes in PRE Fixing layout of PRE levels window Now showing note blocks when dragging. Can now drag notes with relative offset Escape will now cancel drag Fixing rebase Removing code that accidentally undid PR musescore#6006 Fixing text, can now set voices of selected notes.
blackears
force-pushed
the
278988-paste-non-contigious-notes-in-PRE-2
branch
from
2a93351 to
be8a618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can now copy and paste notes in piano roll editor using the right click menu.