Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 302571: Disappearing beam while editing slur node #5918

Merged

Conversation

njvdberg
Copy link
Contributor

@njvdberg njvdberg commented Apr 9, 2020

Resolves: https://musescore.org/en/node/302571

The cross measure beaming algorithm takes system breaks into account, but only when the
first chord of the cross measure beam was part of layout range.
When the layout range starts with measure contains mid/end notes of the cross measure
beam, the break in the cross measure beam due to a system break was recognized when this
was an explicit system break only (e.g. by placing System or Page Break element). Any
system breaks generated by the auto-placer were ignored. As a result a partial layout
(e.g. triggered by an edit) would remove the hook of the "broken" cross measure beam because
the auto-placer assumed it was beamed to a note in the previous measure.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [n.a.] I created the test (mtest, vtest, script test) to verify the changes I made

The cross measure beaming algorithm takes system breaks into account, but only when the
first chord of the cross measure beam was part of layout range.
When the layout range starts with measure contains mid/end notes of the cross measure
beam, the break in the cross measure beam due to a system break was recognized when this
was an explicit system break only (e.g. by placing System or Page Break element). Any
system breaks generated by the auto-placer were ignored. As a result a partial layout
(e.g. triggered by an edit) would remove the hook of the "broken" cross measure beam because
the auto-placer assumed it was beamed to a note in the previous measure.
@anatoly-os anatoly-os merged commit dda133f into musescore:master Apr 21, 2020
@njvdberg njvdberg deleted the issue-302571-disappearing-beam branch April 23, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants