Clarify the text for ambitus update range. Add tooltip. #5854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecstrema
changed the title
Spire42
reviewed
Mar 20, 2020
ecstrema
force-pushed
the
ambitus-match-range
branch
from
b2c9bd6 to
626bcd4
Compare
|
@anatoly-os Could that one possibly be merged before 3.5? |
| @@ -846,8 +846,11 @@ | |||
| <property name="focusPolicy"> | |||
| <enum>Qt::TabFocus</enum> | |||
| </property> | |||
| <property name="toolTip"> | |||
| <string>Adjust the range of the ambitus to match the range of the notes that are currently on the staff.</string> | |||
There was a problem hiding this comment.
"...currentl used on..."?
There was a problem hiding this comment.
I cannot say myself. I don't feel like the "used" is necessary.
I'll add it if someone agrees with you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button's text was not clear. After a discussion on telegram (starting here, and ending there), a viable option seemed to be "Match Staff".
The (not set in stone) tooltip is here set to "Search through the staff for lowest and highest notes, and update the ambitus' range accordingly."
As english is not my first langage, I would appreciate feedback on the this.