Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #298955: Duplicate elements applied for each note in chord with range selection #5560

Conversation

IsaacWeiss
Copy link
Contributor

No description provided.

@IsaacWeiss
Copy link
Contributor Author

See https://musescore.org/en/node/298955. For some palette elements, such as accidentals and noteheads, the current behavior (applying one for each note in the chord) is important to retain; are there other element types that should be excepted?

@dmitrio95
Copy link
Contributor

Isn't this the same what #5437 is intended to fix? Anyway, I am honestly not fully happy with both of the proposed solutions. It seems to me that the ideal solution should try to avoid adding identical element to the same parent (drop target is often different to actual parent of the dropped element) without explicitly handling the respective elements' and their parents' types. Even if it happens so that the best way to implement this solution results in larger changes (it doesn't currently seem to be possible to easily figure out which type would a parent of an arbitrary element added to a score have) such solution would definitely be better to maintain in a long term.

@njvdberg
Copy link
Contributor

#5437 prevents multiple text elements when multiple notes are selected.

@IsaacWeiss
Copy link
Contributor Author

IsaacWeiss commented Apr 24, 2020

Even if it happens so that the best way to implement this solution results in larger changes (it doesn't currently seem to be possible to easily figure out which type would a parent of an arbitrary element added to a score have) such solution would definitely be better to maintain in a long term.

To be sure. In the shorter term, though, without those larger changes, are there any objections to this method of only adding once to each chord? This is a problem that very frequently annoys me when I write, and not only with text elements (as in #5437) but often with symbols from the Master Palette.

@anatoly-os anatoly-os merged commit 9a9ae7a into musescore:master Apr 28, 2020
@IsaacWeiss
Copy link
Contributor Author

Thanks!

@IsaacWeiss IsaacWeiss deleted the 298955-palette-chord-duplicate-elements branch April 28, 2020 16:33
@njvdberg njvdberg mentioned this pull request May 3, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants