Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #123141: Playback panel: Turning loop OFF leaves loop in/out buttons ON #6015

Conversation

Spire42
Copy link
Contributor

@Spire42 Spire42 commented Apr 29, 2020

Resolves: #123141

Fixed a problem with the “Loop In” and “Loop Out” buttons in the Play Panel that caused them to visually appear as toggle buttons even though functionally they are actually simple pushbuttons.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

…ons ON

Fixed a problem with the “Loop In” and “Loop Out” buttons in the Play Panel that caused them to visually appear as toggle buttons even though functionally they are actually simple pushbuttons.
@anatoly-os anatoly-os merged commit 675b4bc into musescore:master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants