Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage: give execute permission on scripts to Group and World #5962

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

shoogle
Copy link
Contributor

@shoogle shoogle commented Apr 16, 2020

Resolves: no issue in tracker

Old permissions: rwxr--r-- (Owner can execute)
New permissions: rwxr-xr-x (Owner, Group and World can execute)

Owner execute is not enough because the files are owned by root at runtime
(the AppImage is mounted this way by FUSE). Normally the permissions are
ignored, but they matter when trying to run the AppImage inside a sandbox
with an application like Firejail.

See AppImage/appimage.github.io#1943

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [N/A] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [N/A] I created the test (mtest, vtest, script test) to verify the changes I made

Old permissions: rwxr--r-- (Owner can execute)
New permissions: rwxr-xr-x (Owner, Group and World can execute)

Owner execute is not enough because the files are owned by root at runtime
(the AppImage is mounted this way by FUSE). Normally the permissions are
ignored, but they matter when trying to run the AppImage inside a sandbox
with an application like Firejail.
@anatoly-os anatoly-os merged commit a97f7e4 into musescore:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants