-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU3] Update Bravura to 1.39 #5934
Conversation
It looks like the vtest is still failing because in the current output of the PR, the wiggles on the downward-pointing arpeggiatos are now left-to-right mirror images of the way they used to look. If this new output is correct (and according to Gould's Behind Bars, it is — I just checked), then you need to update the vtest. |
The vtests are showing differences indeed, but they are pretty minor as far as I can tell and there's no need to update the vtests, not for this PR anyway. A general overhaul of all vtests though would be worth a separate PR, one day, maybe after 3.5 release. Many of the scores used there still stem from MuseScore 2.x, a direct comparison of the ref files with the current ones would show huge differences, this CI_test just compares between 2 subsequent commits, not against those ref files. |
I don't think the issues with the symbols are worth updating the font version. At least, not before fixing those issues. |
Fixing what issues? There is none as far as I can tell. There was one reg. arpeggio, but that's fixed now. |
oops, update to 1.37 needed meanwhile, done |
And now updated to 1.39 |
and match the orginal filenames from Steinberg to ease further updates
by not using `SymId::wiggleArpeggiatoDownArrow` in a `symbolLine()` for an `ArpeggioType::DOWN`, but using the same line as for `ArpeggioType::UP`, just turned upside down.
As taken fresh from https://github.com/steinbergmedia/bravura
Follow up to #4879, which updated it to 1.32