Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Update Bravura to 1.39 #5934

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Apr 13, 2020

As taken fresh from https://github.com/steinbergmedia/bravura
Follow up to #4879, which updated it to 1.32

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Apr 13, 2020

Most of the vtest differences are very minor and to be expected. But the one for arpeggios is not:
Before:
bravura-8-ref
after:
bravura-8-1
Note the wiggly down arrow arpeggio, which is just plain wrong. From the FONTLOG.txt:
Swapped direction of wiggleArpeggiatoDownArrow (U+EAAE) and wiggleArpeggiatoDownSwash (U+EAAC), which pretty much explains this.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Apr 13, 2020

Fixed it to this:
bravura-8-1

@Spire42
Copy link
Contributor

Spire42 commented Apr 17, 2020

It looks like the vtest is still failing because in the current output of the PR, the wiggles on the downward-pointing arpeggiatos are now left-to-right mirror images of the way they used to look.

If this new output is correct (and according to Gould's Behind Bars, it is — I just checked), then you need to update the vtest.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Apr 17, 2020

The vtests are showing differences indeed, but they are pretty minor as far as I can tell and there's no need to update the vtests, not for this PR anyway.
There are larger differences for the "wiggly down arpeggios" though, due to the fact that they now wiggle differently vs. before (see the images above, very closely), as they now are basically just "wiggly up arpeggios" turned 180°, as apparently the change Daniel Spreadbury did to the font, esp. to the wiggleArpeggiatoDownArrow, doesn't work well with our implementation of symbolLine().

A general overhaul of all vtests though would be worth a separate PR, one day, maybe after 3.5 release. Many of the scores used there still stem from MuseScore 2.x, a direct comparison of the ref files with the current ones would show huge differences, this CI_test just compares between 2 subsequent commits, not against those ref files.

@Jojo-Schmitz Jojo-Schmitz changed the title update Bravura to 1.36 Update Bravura to 1.36 Apr 20, 2020
@anatoly-os
Copy link
Contributor

I don't think the issues with the symbols are worth updating the font version. At least, not before fixing those issues.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Apr 21, 2020

Fixing what issues? There is none as far as I can tell. There was one reg. arpeggio, but that's fixed now.

@Jojo-Schmitz Jojo-Schmitz changed the base branch from master to 3.x May 8, 2020 07:26
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented May 13, 2020

oops, update to 1.37 needed meanwhile, done

@Jojo-Schmitz Jojo-Schmitz changed the title Update Bravura to 1.36 Update Bravura to 1.37 May 13, 2020
@Jojo-Schmitz Jojo-Schmitz changed the title Update Bravura to 1.37 Update Bravura to 1.39 Jul 6, 2020
@Jojo-Schmitz
Copy link
Contributor Author

And now updated to 1.39

and match the orginal filenames from Steinberg to ease further updates
by not using `SymId::wiggleArpeggiatoDownArrow` in a `symbolLine()`
for an `ArpeggioType::DOWN`, but using the same line as
for `ArpeggioType::UP`, just turned upside down.
@MarcSabatella MarcSabatella added the vtests This PR produces approved changes to vtest results label Aug 25, 2020
@Jojo-Schmitz Jojo-Schmitz changed the title Update Bravura to 1.39 Update Bravura to 1.39 (3.x) Oct 20, 2020
@Jojo-Schmitz Jojo-Schmitz changed the title Update Bravura to 1.39 (3.x) [MU3] Update Bravura to 1.39 Oct 20, 2020
@vpereverzev vpereverzev merged commit 70222c9 into musescore:3.x Oct 23, 2020
@Jojo-Schmitz Jojo-Schmitz deleted the bravura branch October 23, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants