Add reveal in finder (show in explorer) option in metaedit dialog. #5646
Conversation
|
It'd be "+ collect_artifacts" and would help Windows users only |
ecstrema
force-pushed
the
metareveal
branch
3 times, most recently
from
083f064 to
120cf58
Compare
|
Is there any mac user that could test this branch? I can use a mac at school, but can't build MuseScore with it, and apparently collect_artifacts only works for mac. |
|
Ciao Marr11317, I tested the PR under Linux Mint 19.3 (Cinnamon desktop environment) and it works, i.e. it opens the folder in Nemo file manager when clicking on the little folder icon in the Score Properties. As expected, it doesn't work (it does nothing) with the default My_First_Score.mscx (residing in internal address :/data) and it emits in the console the following warning |
ecstrema
force-pushed
the
metareveal
branch
3 times, most recently
from
a61ca98 to
8e9262a
Compare
|
@dmitrio95 @anatoly-os This one is ready I think. It may conflict with #5633, so it'd be better to merge one of the two as soon as possible so that I can resolve the merge conflicts before springtime. |
|
This would also leave some time for translators before the next release. Both PRs have a few strings. |
mscore/metaedit.cpp
Outdated
| // openFileLocation | ||
| //--------------------------------------------------------- | ||
|
|
||
| void MetaEditDialog::openFileLocation(const QString& path, QWidget* parent) |
There was a problem hiding this comment.
I think this method should be in a separate class, for example OpenFileLocation::open
So that in the future we can see what it is and reuse it in another place where it is needed.
In the same class, you can put the title definition logic (Explorer, Finder and etc)
|
rebase needed |
rebased |
ecstrema
force-pushed
the
metareveal
branch
3 times, most recently
from
6af5e45 to
d94021f
Compare
…on in metaedit dialog.
|
Translations don't work, the strings show on Transifex but even if translated there and translations updated they still show untranslated. Came up in the MuseScore translators chat and I'm looking into fixing this... see #5994 |
Previously, the path shown in metaedit dialog had been set as selectable by mouse. I guess this was to be able to copy it into explorer or wherever needed. This is even faster.
It works on my machine, windows 10. However, it would be really appreciated if someone could test it under Macos and Linux.