Add the ability to close score tab by clicking middle button (fix #27371) #5871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harmoniker1
force-pushed
the
tab-middle-button
branch
from
d3a8772 to
50d60da
Compare
dmitrio95
reviewed
Mar 26, 2020
Harmoniker1
force-pushed
the
tab-middle-button
branch
from
50d60da to
6459077
Compare
|
Somehow Travis got stuck on this. Or rather GitHub lost connection to Travis |
|
Will push again later. |
Harmoniker1
force-pushed
the
tab-middle-button
branch
4 times, most recently
from
dc8314e to
403070c
Compare
Spire42
reviewed
Apr 1, 2020
Harmoniker1
force-pushed
the
tab-middle-button
branch
2 times, most recently
from
ccb2a3e to
281f663
Compare
Spire42
approved these changes
Apr 17, 2020
Harmoniker1
force-pushed
the
tab-middle-button
branch
from
281f663 to
84fcca2
Compare
| { | ||
| QTabBar::mouseReleaseEvent(e); | ||
| if (e->button() == Qt::MiddleButton) { | ||
| if (tabAt(e->pos()) == _middleClickedTab) |
There was a problem hiding this comment.
It would be nice to have a gesture recognizer that would detect actions and already respond to them. This is not a suggestion to do in this PR, just thoughts.
MsTabBar::MsTabBar() {
_gestureRecognizer = new GestureRecognizer(this); <- setting event filter
connect(_gestureRecognizer, &GestureRecognizer::middleClicked, this, &MsTabBar::onMiddleClicked);
}
igorkorsukov
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/27371.