Get splash screen messages to appear on macOS #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The splash screen image used on macOS is @2x resolution, which means that the width and height of the pixmap are twice the width and height of the splash screen, which meant that the message text was being drawn outside of its window. It is better to just use the widget's own width and height properties to determine the placement of the message text.
Harmoniker1
approved these changes
Apr 26, 2020
mattmcclinch
force-pushed
the
splash-message-fix
branch
from
41cfef0 to
f565510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The splash screen image used on macOS is @2x resolution, which means that
the width and height of the pixmap are twice the width and height of the
splash screen, which meant that the message text was being drawn outside
of its window. It is better to just use the widget's own width and height
properties to determine the placement of the message text.
The first commit solves the issue of messages not appearing on the splash screen on macOS.
The second commit simplifies the MsSplashScreen class so that it contains no more code than what is necessary for displaying a message in a custom location, which is really the only thing that the MsSplashScreen class offers in the first place.