Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Backup File] fix #125656: put the backup file in a separate folder" #6016

Closed
wants to merge 1 commit into from

Conversation

shoogle
Copy link
Contributor

@shoogle shoogle commented Apr 29, 2020

Reverts #5380

There could be countless programs making files or folders called .backup. Besides, it is standard practice for text editors and other programs to save backup files in the same folder as the original.

Copy link
Contributor

@Spire42 Spire42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly disagree with the changes made in PR #5380 and would definitely like to see them reverted.

@ecstrema
Copy link
Contributor

ecstrema commented Apr 30, 2020

Then just set the folder to .mscbackup
No need to revert the whole PR

@ecstrema
Copy link
Contributor

see #6017

@Harmoniker1
Copy link
Contributor

I agree with @Marr11317 here. The decision of putting backup files in a separate folder was made by many in the community back then. If .backup is not good, another name is sufficient.

@Jojo-Schmitz
Copy link
Contributor

I'm for keeping this change too. It had been discussed at length back then.
Improving it by giving a better name for the backup directory and/or make it configurable though is a good idea

@jeetee
Copy link
Contributor

jeetee commented Apr 30, 2020

Another vote for not reverting this.

The decision to start using a backup folder iso polluting the current directory was made after a good discussion taking many use cases and viewpoints into consideration. It serves to remove the confusion between normal and backup/hidden files; which are a source of user aggravation especially for Windows users not even aware of them being hidden and/or not seeing the extensions.

I also disagree that a .backup folder in the current working directory would lead to application conflicts for most users, but a simple change to make it .mscbackup would already avoid that.

The strength of the counterargument is rather weak to me as well. One the one hand you don't want this directory as "countless other programs" are doing that too and it would lead to collisions/conflicts. On the other hand you're claiming we shouldn't be doing it as it isn't common practice at all...

@shoogle
Copy link
Contributor Author

shoogle commented Apr 30, 2020

One the one hand you don't want this directory as "countless other programs" are doing that too and it would lead to collisions/conflicts. On the other hand you're claiming we shouldn't be doing it as it isn't common practice at all...

I was talking about different types of program. I don't know of any editor programs that place autosave backups in a special directory. There must surely be other software (think backup / data recovery programs) that uses .backup as a file or folder name.

The decision to start using a backup folder iso polluting the current directory was made after a good discussion taking many use cases and viewpoints into consideration.

I don't see this conflict mentioned anywhere in that discussion.

@anatoly-os
Copy link
Contributor

See #6017. .mscbackup directory is a nice idea.

@anatoly-os anatoly-os closed this Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants