Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #300124: Add default shortcut for synthesizer as Shift+F12 #5642

Closed

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Jan 25, 2020

@Jojo-Schmitz Jojo-Schmitz changed the title add default shortcut F7 for synthesizer fix #300124: add default shortcut F7 for synthesizer Jan 25, 2020
@Jojo-Schmitz
Copy link
Contributor Author

F7 surely is free on Windows, not sure about Mac though?

@Spire42
Copy link
Contributor

Spire42 commented Apr 17, 2020

I like the idea of adding a default keyboard shortcut for the Synthesizer dialog, but function keys are such a scarce resource that I can't help but wonder if this dialog would be the best use for F7.

Perhaps it would be better to use F7 for, say, the Navigator? The Navigator seems like a good candidate because unlike the Synthesizer dialog, it's a panel just like all of the other items that currently have function keys assigned to them.

Another possible candidate is the Score Comparison Tool, although I suspect that it's not used nearly as often as the Navigator.

Yet another possible candidate is the Piano Keyboard. Although it already has P assigned to it, it's the only panel that's assigned a non-function key, so it sticks out like a sore thumb.

It would be instructive to look at the telemetry data to see which of the items on the View menu that don't yet have a keyboard shortcut is the most frequently used.

@MarcSabatella
Copy link
Contributor

MarcSabatella commented Apr 17, 2020

Navigator is, to me, all but obsolete, and I don't see the need to reserve a shortcut for it. I suppose the small percentage of people who use it, probably use it a lot, but they can define their own shortcut.

Note though that we will probably be needing to shuffle the function key shortcuts some because F6 is really supposed to be reserved for accessibility (see #5920, which for now is moving Selection Filter to F7).

Anyhow, I do agree Synthesizer should get a default shortcut if possible, and I would be OK with seeing Timeline lose its shortcut in the process. So, F6 for accessibility, F7 for selection filter, F12 for synth is one possibility. I like keeping the playback-related shortcuts together, mixer/play panel/synth as F10/F11/F12.

@ecstrema
Copy link
Contributor

ecstrema commented Apr 18, 2020

Navigator is, to me, all but obsolete

@MarcSabatella Why do you think that the navigator is now obsolete? I recently haven't used it often, but I haven't been working on any large score either. Is there a better approach to navigate through the score? And why wasn't it obsolete at one point?

It could get a new look though (like being a dock like all others), but if it did, I believe that it still could be of great utility.

@MarcSabatella
Copy link
Contributor

The usual way to navigate through scores is the scroll wheel, no additional aids are normally needed at all. And ever since the Timeline was added, it has mostly replaced whatever use cases formerly might have led one to use the Navigator, which is why it took over the F12 shortcut that was once used for the Navigator.

@ecstrema
Copy link
Contributor

ecstrema commented Apr 18, 2020

The timeline may be attractive to experienced users, but is way less user-friendly and self-explanatory.
I would definitely not get rid of the navigator in for the timeline. I actually find the timeline too cluttered too be of any use in complex/large scores. And that is exactly when navigation becomes important.
However, I must admit that I did not use the timeline enough to get familiar with it.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Apr 18, 2020

I'm still using the navigator too. No need for a shortcut though IMHO

Note though that we will probably be needing to shuffle the function key shortcuts some because F6 is really supposed to be reserved for accessibility (see #5920, which for now is moving Selection Filter to F7).

Anyhow, I do agree Synthesizer should get a default shortcut if possible, and I would be OK with seeing Timeline lose its shortcut in the process. So, F6 for accessibility, F7 for selection filter, F12 for synth is one possibility. I like keeping the playback-related shortcuts together, mixer/play panel/synth as F10/F11/F12.

F12 seemed a good idea, but is "Toggle Timeline" already, so not an option, not without loosing the current setting. OTH I don't see why timeline needs a shortcut, but that may be just me...

@MarcSabatella
Copy link
Contributor

MarcSabatella commented Apr 18, 2020

No one is suggesting getting rid of the timeline; just not wasting a default shortcut on it. As I said, for the vast majority of scores, you don't need anything on screen to navigate your scores - scroll wheel works perfectly already. So for most users most of the time, no shortcut is needed at all, which is why I'd prefer to see F12 made available for something more valuable if there is another window that needs a shortcut, and synthesizer does seem the most natural choice.

As for the timeline, I agree it can look overwhelming at first, but I think if you do give it a shot, you'll find it much more valuable than the navigator. Again, in the vast majority of cases you don't need either - scroll wheel is great, plus shortcuts like PgUp/Down, Ctrl+Home/End, Ctrl+F, etc. But in those few cases where a score is sufficiently long and complex where you might need more, the timeline provides a ton of really useful functionality to help you find your way around according to rehearsal marks, tempo change, key changes, instrument entrance etc. I definitely recommend spending some time with it to get more comfortable with it. But then, probably keeping it closed most of the time because it normally isn't needed.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Apr 18, 2020

Nobody suggested to get rid of timeline.
OK, so 'steal' F12 from timeline and use for synthesizer?
Done...

@Jojo-Schmitz Jojo-Schmitz force-pushed the synthesizer-shortcut branch from c9f883e to 0d4ea18 Compare April 18, 2020 15:48
@Jojo-Schmitz Jojo-Schmitz changed the title fix #300124: add default shortcut F7 for synthesizer fix #300124: add default shortcut for synthesizer Apr 18, 2020
@MarcSabatella
Copy link
Contributor

FWIW, I was responding to the statement "I would definitely not get rid of the navigator in for the timeline" and simply pointing out that indeed no one has suggested this.

So yes, to the extent we want a shortcut for synthesizer, stealing from timeline seems good to me. I guess Shift+F10 or the like would have been a possibility too. But I know function keys are problematic on some systems 0 might be non-existed, might be reserved by the system, etc. - and combinations with modifiers possibly even more so.

@Jojo-Schmitz Jojo-Schmitz force-pushed the synthesizer-shortcut branch from 0d4ea18 to 29398cd Compare April 20, 2020 06:21
@Jojo-Schmitz Jojo-Schmitz changed the title fix #300124: add default shortcut for synthesizer Fix #300124: Aadd default shortcut for synthesizer Apr 20, 2020
@Jojo-Schmitz Jojo-Schmitz changed the title Fix #300124: Aadd default shortcut for synthesizer Fix #300124: Add default shortcut for synthesizer Apr 20, 2020
@Jojo-Schmitz Jojo-Schmitz force-pushed the synthesizer-shortcut branch from 29398cd to 67eb919 Compare April 20, 2020 09:58
@anatoly-os
Copy link
Contributor

Won't be really user-friendly for the ones who get used to showing/hiding Timeline using F12. Why not something like Ctrl+F10 since Synth is almost like Mixer :)

FYI, F11 doesn't work on maOS at all. This is a system shortcut that hides all opened windows...

@Jojo-Schmitz Jojo-Schmitz force-pushed the synthesizer-shortcut branch from 67eb919 to f655217 Compare April 21, 2020 19:53
@Jojo-Schmitz
Copy link
Contributor Author

OK, done

@Jojo-Schmitz Jojo-Schmitz changed the title Fix #300124: Add default shortcut for synthesizer Fix #300124: Add default shortcut for synthesizer as Shift+F12 Apr 21, 2020
@MarcSabatella
Copy link
Contributor

I don't have good insight into which key combinations are available on which systems. I've used plenty that have no function keys at all, or stop at F10, and I know some Linux installations reserve some things too.

But, regarding the fact that taking the F12 shortcut from timeline might surprise users - sure, but it's a small number of users who rely on this, and they can easily customize if they like. Compared to other changes we've made lately and are proposing - the "new" palettes, the change to accidental input, etc - it's nowhere near as big a deal. I doubt we'll get 1/100th as many complaints.

@Spire42
Copy link
Contributor

Spire42 commented Apr 21, 2020

On the subject of accessibility, one thing that no one has mentioned yet is that both F10 and Shift+F10 are reserved system shortcuts under Windows: the former activates the application menu and the latter opens the context menu for the item with the input focus. (And MuseScore currently hijacks F10.)

If we're ruling out system-reserved shortcuts, in addition to the above we've got F11 and F12 on the Mac (as @anatoly-os has mentioned).

I strongly suggest that we take this opportunity to rethink all of the default function-key shortcuts rather than just commit to a single new one here. I think a forum thread would be a good open place to do so.

@anatoly-os
Copy link
Contributor

Ok, I agree with @Spire42 and suggest revising the shortcuts later.

@anatoly-os anatoly-os closed this Apr 21, 2020
@Jojo-Schmitz Jojo-Schmitz deleted the synthesizer-shortcut branch April 21, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants