-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #16077 part 1: Double click an instrument name to open the corresponding menu #5886
Conversation
Opening the staff properties dialog is not exactly the selected as allowing to edit the instrument name in place though. |
From what I understand the user wants the ability to double click to open the corresponding menus in both cases. He moves on to say that it would be ideal if he could edit-in-place but this is not the main focus of the issue (as its title suggests). Giving the ability to edit in place would be truly ideal, but it would probably require reworking the entire Instrument-system-iname chain of interactions. |
No objection from me, just pointing out the shortcomings of this solution. |
Fixed formatting and added a return statement. |
I like the idea a lot. Any possibility the same could be done for header/footer? I'm not as sure it's possible, at least, not as simply - I kind of doubt the header/footer register here. But worth a shot. |
@MarcSabatella I am actually finishing the PR for that right now. :-) |
mscore/events.cpp
Outdated
return; | ||
else if (!clickedElement->isEditable()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no need for else
if (!clickedElement)
return;
if (!clickedElement->isEditable()) {
...
return
}
...
I made the changes which were suggested. |
…he corresponding menu
Resolves: https://musescore.org/en/node/16077
When the double-click event is created, the program checks if the user double-clicked on an instrument-name and opens the 'Edit Staff/Part Properties' menu if that is the case.
This provides one part of the requested functionality (the other, is to add the same ability for footers, but this should be another PR).