Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piano Roll Editor Keyboard Zoom #5814

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

blackears
Copy link
Contributor

Allow the user to zoom the Piano Roll Editor window using the keyboard.

mscore/pianoview.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@Harmoniker1 Harmoniker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the (no) changes to the .md and .txt files for? Please don't include irrelevant changes in this commit.

mscore/pianoview.cpp Outdated Show resolved Hide resolved
mscore/pianoview.cpp Outdated Show resolved Hide resolved
mscore/pianoview.cpp Outdated Show resolved Hide resolved
mscore/pianoview.cpp Outdated Show resolved Hide resolved
mscore/pianoview.cpp Outdated Show resolved Hide resolved
mscore/pianoview.h Outdated Show resolved Hide resolved
mscore/pianoview.h Outdated Show resolved Hide resolved
@blackears blackears force-pushed the 289425-PRE-keyboard-zoom-2 branch 5 times, most recently from 75ae0b8 to ef913f1 Compare March 20, 2020 14:44
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Mar 20, 2020

No such shortcuts for macOS and/or AZERTY?

Why share/sound/MuseScore_General-License.md and share/sound/MuseScore_General-changelog.txt ?

mscore/shortcut.cpp Outdated Show resolved Hide resolved
mscore/shortcut.cpp Outdated Show resolved Hide resolved
mscore/shortcut.cpp Outdated Show resolved Hide resolved
mscore/shortcut.cpp Outdated Show resolved Hide resolved
mscore/pianoroll.cpp Outdated Show resolved Hide resolved
@RobFog
Copy link

RobFog commented Apr 17, 2020

Rebase needed.

Allow the user to zoom the Piano Roll Editor window  using the keyboard.

Ctrl - and Ctrl = will zoom horizontally
Ctrl Alt - and Ctrl Alt = will zoom vertically.
Adding keypresses to enable zoom in PRE.

Can now also use Alt to zoom window

Using shortcut system to listen to keyboard input.

Fixing indent

Removing unused code.

Making WsWidget a regular enum.

Making shortcut name clearer.

Fixing text, removing unneeded files.

Fixing text, removing unneeded files.
@blackears blackears force-pushed the 289425-PRE-keyboard-zoom-2 branch from a5ac692 to e0566e1 Compare April 17, 2020 12:05
@anatoly-os anatoly-os added the strings Affects translatable strings label Apr 21, 2020
@anatoly-os anatoly-os merged commit 620936b into musescore:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
strings Affects translatable strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants