-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix related to #93376: Added smooth scrolling controls and preferences for continuous view #5898
fix related to #93376: Added smooth scrolling controls and preferences for continuous view #5898
Conversation
2700550
to
b27c236
Compare
Should be ok now, uploaded the wrong thing. |
rebase needed |
6014ab9
to
b555995
Compare
Rebase completed. |
b555995
to
5f41f15
Compare
Fixed formatting and replaced QTimer with QElapsedTimer. |
The continuous scrolling feature is very welcome and well implemented. I think the following two points are missing, either as default behaviour or advanced settings:
I also observed that the smoothness took a considerable drop when the Timeline view was also enabled. I have an Intel i9 9900K and vVidia 1080 Ti so I don't know if anything can be done about this. I hope the feedback is valuable. |
@Ryzza5 I will look into all of the issues/suggestions. Your feedback is very valuable :^) side note: I believe that this should have been (and should be) posted at https://musescore.org/en/project/issues/musescore |
See the Advanced tab of the preferenecs dialog. For further questions on how to use MsueScore, please see the Support forum on musescore.org. |
Found it. Thanks @MarcSabatella |
Resolves: https://musescore.org/en/node/93376
Added the ability to smoothly pan in continuous view, during playback (gif with terrible framerate below, in reality, it's smooth :^). For that to happen, a second 'control-cursor' is used. The view follows this cursor. The speed of the control-cursor is influenced by the distance between it and the playback-cursor and by the time elapsed between each update (tied to the heartbeat, every 20ms as of right now).
The variables used in the calculations have been added to the preferences. Some of them are hidden (and commented out, that way they can be easily enabled in the future), the rest is available in the advanced tab. If the users request more control over the behavior I have prepared a separate tab used to control all the variables (as shown in the images), but that has been removed from this PR.
Alternative preferences, if that's required:
![image](https://user-images.githubusercontent.com/21060365/78454817-20303b00-76a3-11ea-9a67-ce1a53f65624.png)
![image](https://user-images.githubusercontent.com/21060365/78454819-26261c00-76a3-11ea-957a-63c2fcb2565e.png)