Use palette background color for keysig chooser in the New Score Wizard #5959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoogle
force-pushed
the
keysig-background
branch
from
0b3d87d to
26daa6f
Compare
shoogle
changed the title
Spire42
approved these changes
Apr 17, 2020
Especially helpful when the Dark Theme is applied. Qt uses a dark background by default which makes the black palette icons difficult to see.
shoogle
force-pushed
the
keysig-background
branch
from
26daa6f to
e0afd99
Compare
igorkorsukov
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: no issue in tracker
This PR makes the background the same almost-white colour as is used in the palettes. Previously, the keysig chooser was using Qt's default background color, which is dark when the Dark Theme is loaded. This made the icons difficult to see.