Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update master #49

Merged
merged 2,882 commits into from
Jul 22, 2022
Merged

update master #49

merged 2,882 commits into from
Jul 22, 2022

Conversation

hnnajh
Copy link
Owner

@hnnajh hnnajh commented Jul 22, 2022

Problem

What is being fixed? Examples:

Change overview

What's in this PR

Testing

How was this tested? (at least one bullet point required)

  • If unit tests were added, how do they cover this issue?
  • If unit tests existed, how were they fixed/modified to prevent this in future?
  • If new unit tests are not added, why not?
  • If integration tests were added, how do they verify this change?
  • If new integration tests are not added, why not?
  • If manually tested, what platforms controller and device platforms were manually tested, and how?
  • If no testing is required, why not?

mspang and others added 30 commits July 7, 2022 08:53

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
via pip-compile requirements.txt -o constraints.txt

Note that mbed-tools is not installable currently.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* [#19622] Return generic failure instead of not found for schedule operations in the door lock

* [#19563] Check enum ranges for Door Lock commands
- Refactor the cluster, so it is consistent in way of handling commands

* Refactoring of the door lock cluster: move credential error checking into a single function, fix typos

* Fix tests for Door Lock cluster and run them against the lock app

* Update auto-generated files

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The "discover" name will align with the DiscoveryFilter parameter
used by these functions.
* Default initialize controller vendor ID

Problem:
The Python REPL was failing to commission a device when built with
detail logging disabled.

Cause:
It was not correctly initializing the
Controller::SetupParams::controllerVendorId when creating a commissioner
instance. This resulted in it using garbage values that sometimes, were
correct and not zero.

Fix:
As per discussion here, this default initializes that field to
VendorId::Unspecified as well as adding an early check for a valid value
at controller creation time. This ensures that applications creating
commissioners are forced to explicitly provide a value for their vendor
ID. It also ensures we catch applications who don't do so early at
commissioner instantiation time.

Testing:
Validate that the REPL and REPL tests pass correctly.
For other platforms, will have to check the various PR tests and see
which ones fail.

* Review feedback

* Rebase and fix-up test logic that got added recently

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Device info provider added

* Restyled by astyle

* Restyled by clang-format

* Just trying to trigger CI

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Added PICS condition

* Added Auto genearted file

* Restyled by whitespace

* Restyled by clang-format

* removed unused PICS values

* Added Auto generated files

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Update android builds:

- fix naming to remove CHIP_ prefix (too repretitive)
- fix artifact names for TV app as it is split in content and platform
  sides. Verfied by running:

```
./scripts/build/build_examples.py --target android-arm64-chip-tvserver build --copy-artifacts-to out/artifacts
```

* Update naming build build_all to remove some of the chip prefixes

* Fix glob for full android builds now that chip prefix was removed

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ch queue from MTRDeviceController (#20439)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Updating SVE rules

* Fixing paths

* Adding tests for cherry pick

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
- stackSize
- stackFreeCurrent

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Enable darwin-framework-tool compilation and tests.

* Generate code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
And switch to clang which also removes the need for shared libstdc++.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Fix Python Threading Model

This fixes a number of issues with the Python REPL's threading model,
namely:

- Multiple, duplicated methods for stack initialization.
- Stack initialization split across really odd places
- Incorrect thread initialization
- Incorrect order of initialization

* Review feedback

* Brought back the auto-stack init in native, albeit, a minimal version
only.

Updated ChipStack to now use native to implicitly achieve this auto init
(which sets up MemoryInit) before continuining onwards with
controller-style initialization.

* Fix build

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Some compilers (some ARM-based Linux compilers) have difficulty
inferring the return type of lambdas that don't explicitly state their
return type. This causes issues when passing lambdas as arguments into
functions that expect a specific function signature.

This fixes this specific instance in CASEServer that has this problem.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Move AddNOC and UpdateNOC to util functions that can be called using chip-repl

* Restyle

* Address PR comments

* Address PR comments

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Adds fix for IPV6 multicast

* Revert LwIP options

* Adds fix for warning on ESP32 toolchain

* Adds changes to incorporate InterfaceId:Null() for LWIP

* Add IPv4 support for non-interface join/leave group

* Fix some typos - compile tested with esp32

* Reformat code for readability and consistency

Co-authored-by: Andrei Litvin <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…rite onto a single transation does not collide with the comma separator from the argument value itself (#20413)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The Python implementation of the PersistentStorageDelegate::SyncDeleteKey API
was not actually syncing the deleted key back to the underlying JSON
file, resulting in the deletion not actually 'sticking' despite passing
the storage audit.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Add Event TimeStamp

* Restyled by google-java-format

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Fix 2 door lock edge cases

* remove check of lower bound for credential index

* remove unused function declaration

Co-authored-by: Restyled.io <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…20431)

* Enforce constraints for sizes of labelstruct label and value lengths

* Add a test user label cluster constraint integration test

* regen for tests

* Restyle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
When there was no support for Last Known UTC Time in the
common code we added a similar but incomplete solution
to the Zephyr platform code that initializes the real time
clock to the firmware build time.

That solution is incorrect as it doesn't allow for updating
the Last Known UTC Time, so we should rather return an error
if no time synchronization is in place.

Signed-off-by: Damian Krolik <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Fix UpdateNOC session invalidation and opcreds timing

- UpdateNOC did not clear session of previous fabric like spec intended
  (#20379)
- All OpCreds cluster slow commands did not try to early-ack to avoid
  MRP timeouts (#19132)

Fixes #20379
Fixes #19132

This PR:

- Fixes UpdateNOC expiring all sessions for the updated node
- Adds `FlushAcksRightAwayOnSlowCommand` to CommandHandler to flush acks
  on slow commands
- Adds Python tests for UpdateNOC behavior of session expiring
- Adds `ExpireSessions` to Python for testing

Testing done:

- Unit tests all pass
- Cert tests pass
- With the session clearing, previous Python tests failed, until
  I fixed them with the new `ExpireSessions` API
- Observed standalone acks immediately sent on opcreds cluster commands

* Restyled

* Removed leftover debug
DamMicSzm and others added 19 commits July 21, 2022 17:48
…#21046)

* Fix storage location of Docker images and containers for osx or linux
This will fix information about used memory space when build image of docker on osx host machine. Docker has another directory on linux and osx.

* Fixed styling problem

* Improved system checking and path mapping for docker volume
As of 61dd4d0 ("[python] Split Python wheel in two separate wheels (#20054)")

ninja will forever try to regenerate this file because the filename is
specified incorrectly:

  ninja: Entering directory `out/debug'
  ninja explain: output linux_x64_gcc/controller/python/chip_repl-0.0-py3-any.whl doesn't exist
  ninja explain: linux_x64_gcc/controller/python/chip_repl-0.0-py3-any.whl is dirty
  ninja explain: output linux_x64_gcc/controller/python/chip_clusters-0.0-py3-any.whl doesn't exist
  ninja explain: linux_x64_gcc/controller/python/chip_clusters-0.0-py3-any.whl is dirty
  ninja explain: linux_x64_gcc/obj/src/controller/python/chip-repl.stamp is dirty
  ninja explain: linux_x64_gcc/obj/default.stamp is dirty
  ninja explain: obj/host_gcc.stamp is dirty
  ninja explain: obj/default.stamp is dirty
  [2/3] ACTION //src/controller/python:chip-clusters(//build/toolchain/host:linux_x64_gcc)

Fix the filename.
Switch to more targeted testing of just crypto oriented tests for the
MbedTLS build and just tests that need the fake platform for the fake
platform build.

This reduces the blowup in execution time from running the cartesian
product of builds x tests and saves about 30% of default work done by
gn_build.sh.
* Yaml File updates

Updated scripts -
Correct attribute

* REGEN

* Restyled by whitespace

* Restyled by prettier-yaml

Co-authored-by: Restyled.io <[email protected]>
…rmEvents (#20733)

* Only open commissioning window when no fabric exists (lighting-app)
* Update K32W in vscode image to matck K32W dockerfile

* Update path to be k32w_named. This matches #21063
…sarmed. (#21111)

We were allowing opening commissioning windows in the "fail-safe is
busy" state.  We should probably not allow that.
* Remove InsufficientPrivilege no longer used

* ZAP regen

* Zap regen

* Regen zap

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
Main fixes/functionalities brought in this PR:
* add initial enablement for K32W041A/AM
* add linker file fixes for OTA enablement
* add detokenizer support for the elock and
moved the script location to a generic location
* move tinycrypt implementation in a separate class
* enable low power with SDK 2.6.6
* enable MACv2
* refactoring around PDM storage
* add size-optimized BLE libraries

Signed-off-by: Doru Gucea <[email protected]>
Signed-off-by: Marius Tache <[email protected]>
Signed-off-by: Andrei Menzopol <[email protected]>
Co-authored-by: Chirag Bansal <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet