Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nodeid to logs in OperationalDeviceProxy.cpp #21019

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Add nodeid to logs in OperationalDeviceProxy.cpp #21019

merged 3 commits into from
Jul 22, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Some logs would benefit from knowing the nodeid for which they occur.

Fixes #16140

Change overview

Added extra logging (added nodeid to logs)

Testing

Compile only - change is trivial.

@github-actions github-actions bot added the app label Jul 20, 2022
@github-actions
Copy link

github-actions bot commented Jul 20, 2022 •
edited
Loading

PR #21019: Size comparison from 4a56906 to f213acf

Increases (36 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4a56906 f213acf change % change
bl602 lighting-app bl602 (read/write) 1379514 1379578 64 0.0
.text 1050152 1050180 28 0.0
bl602+rpc (read/write) 1424922 1424986 64 0.0
.text 1081808 1081832 24 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 653503 653567 64 0.0
.rodata 101191 101223 32 0.0
.text 551832 551864 32 0.0
pump-app LP_CC2652R7 (read only) 680227 680347 120 0.0
.rodata 88811 88875 64 0.1
.text 590932 590988 56 0.0
pump-controller-app LP_CC2652R7 (read only) 666003 666123 120 0.0
.rodata 84675 84731 56 0.1
.text 580848 580912 64 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584910 584958 48 0.0
.app_xip_area 464308 464356 48 0.0
efr32 lighting-app BRD4161A (read/write) 1085936 1086056 120 0.0
.text 950808 950928 120 0.0
BRD4161A+rpc (read/write) 1140212 1140332 120 0.0
.text 988196 988316 120 0.0
BRD4161A+rs911x (read/write) 972052 972164 112 0.0
.text 808472 808584 112 0.0
lock-app BRD4161A+wf200 (read/write) 1127560 1127680 120 0.0
.text 981332 981452 120 0.0
window-app BRD4161A (read/write) 1079428 1079532 104 0.0
.text 942800 942904 104 0.0
esp32 all-clusters-app c3devkit (read only) 1021766 1021820 54 0.0
(read/write) 1486130 1486194 64 0.0
.flash.rodata 216000 216064 64 0.0
.flash.text 1021766 1021820 54 0.0
m5stack (read only) 1075515 1075571 56 0.0
(read/write) 488160 488216 56 0.0
.flash.rodata 246412 246468 56 0.0
.flash.text 1070131 1070187 56 0.0
k32w light k32w061+release (read/write) 660328 660360 32 0.0
.text 582996 583028 32 0.0
linux all-clusters-app debug (read only) 2977953 2978241 288 0.0
.rodata 264779 264843 64 0.0
.text 2535202 2535426 224 0.0
all-clusters-minimal-app debug (read only) 2823905 2824177 272 0.0
.rodata 265675 265739 64 0.0
.text 2382914 2383122 208 0.0
bridge-app debug+rpc (read only) 2324017 2324289 272 0.0
.rodata 198184 198248 64 0.0
.text 1963810 1964018 208 0.0
chip-tool debug (read only) 10335705 10335977 272 0.0
.rodata 517045 517109 64 0.0
.text 8367444 8367652 208 0.0
chip-tool-ipv6only arm64 (read only) 10072828 10073036 208 0.0
.rodata 481100 481148 48 0.0
.text 8008404 8008564 160 0.0
lighting-app debug+rpc (read only) 2561761 2562049 288 0.0
.rodata 214000 214064 64 0.0
.text 2177506 2177730 224 0.0
lock-app debug (read only) 2526657 2526929 272 0.0
.rodata 229008 229072 64 0.0
.text 2132194 2132402 208 0.0
ota-provider-app debug (read only) 2330241 2330513 272 0.0
.rodata 203800 203864 64 0.0
.text 1963378 1963586 208 0.0
ota-requestor-app debug (read only) 2448825 2449113 288 0.0
.rodata 207552 207616 64 0.0
.text 2069810 2070034 224 0.0
shell debug (read only) 2564465 2564737 272 0.0
.rodata 228082 228146 64 0.0
.text 2178994 2179202 208 0.0
thermostat-no-ble arm64 (read only) 2604004 2604212 208 0.0
.rodata 165740 165788 48 0.0
.text 2197968 2198128 160 0.0
tv-app debug (read only) 3112297 3112569 272 0.0
.rodata 249512 249576 64 0.0
.text 2674530 2674738 208 0.0
tv-casting-app debug (read only) 5365833 5366121 288 0.0
.rodata 333601 333665 64 0.0
.text 4765874 4766098 224 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2448688 2448808 120 0.0
.text 1411332 1411452 120 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176151 116 0.0
rodata 142204 142256 52 0.0
text 812024 812084 60 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156219 120 0.0
rodata 133748 133804 56 0.0
text 801336 801396 60 0.0
p6 all-clusters-app default (read/write) 1685700 1685820 120 0.0
.text 1526096 1526216 120 0.0
all-clusters-minimal-app default (read/write) 1629828 1629932 104 0.0
.text 1470944 1471048 104 0.0
light-app default (read/write) 1549828 1549940 112 0.0
.text 1399248 1399360 112 0.0
lock-app default (read/write) 1587420 1587548 128 0.0
.text 1432368 1432496 128 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798388 798496 108 0.0
text 566528 566578 50 0.0
lighting-app tlsr9518adk80d (read/write) 818436 818544 108 0.0
text 583072 583124 52 0.0
Decreases (4 builds for cc13x2_26x2)
platform target config section 4a56906 f213acf change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 633719 633711 -8 -0.0
.text 555844 555836 -8 -0.0
lock-mtd LP_CC2652R7 (read/write) 183608 183544 -64 -0.0
pump-app LP_CC2652R7 (read/write) 162052 161932 -120 -0.1
pump-controller-app LP_CC2652R7 (read/write) 176396 176276 -120 -0.1
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4a56906 f213acf change % change
bl602 lighting-app bl602 (read/write) 1379514 1379578 64 0.0
.bss 116970 116970 0 0.0
.data 4480 4480 0 0.0
.text 1050152 1050180 28 0.0
bl602+rpc (read/write) 1424922 1424986 64 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1081808 1081832 24 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668119 668119 0 0.0
(read/write) 183128 183128 0 0.0
.bss 74140 74140 0 0.0
.data 3356 3356 0 0.0
.rodata 88319 88319 0 0.0
.text 579484 579484 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633719 633711 -8 -0.0
(read/write) 157708 157708 0 0.0
.bss 73436 73436 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 555844 555836 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 671227 671227 0 0.0
(read/write) 170196 170196 0 0.0
.bss 71204 71204 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594304 594304 0 0.0
lock-mtd LP_CC2652R7 (read only) 653503 653567 64 0.0
(read/write) 183608 183544 -64 -0.0
.bss 66892 66892 0 0.0
.data 3280 3280 0 0.0
.rodata 101191 101223 32 0.0
.text 551832 551864 32 0.0
pump-app LP_CC2652R7 (read only) 680227 680347 120 0.0
(read/write) 162052 161932 -120 -0.1
.bss 71292 71292 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88875 64 0.1
.text 590932 590988 56 0.0
pump-controller-app LP_CC2652R7 (read only) 666003 666123 120 0.0
(read/write) 176396 176276 -120 -0.1
.bss 71412 71412 0 0.0
.data 3276 3276 0 0.0
.rodata 84675 84731 56 0.1
.text 580848 580912 64 0.0
shell LP_CC2652R7 (read only) 660594 660594 0 0.0
(read/write) 186156 186156 0 0.0
.bss 76444 76444 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85090 0 0.0
.text 575188 575188 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581546 581546 0 0.0
.app_xip_area 460096 460096 0 0.0
.bss 64244 64244 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587462 587462 0 0.0
.app_xip_area 461284 461284 0 0.0
.bss 68972 68972 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584910 584958 48 0.0
.app_xip_area 464308 464356 48 0.0
.bss 63452 63452 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1085936 1086056 120 0.0
.bss 133060 133060 0 0.0
.data 2048 2048 0 0.0
.text 950808 950928 120 0.0
BRD4161A+rpc (read/write) 1140212 1140332 120 0.0
.bss 149732 149732 0 0.0
.data 2260 2260 0 0.0
.text 988196 988316 120 0.0
BRD4161A+rs911x (read/write) 972052 972164 112 0.0
.bss 161512 161512 0 0.0
.data 2048 2048 0 0.0
.text 808472 808584 112 0.0
lock-app BRD4161A+wf200 (read/write) 1127560 1127680 120 0.0
.bss 144152 144152 0 0.0
.data 2056 2056 0 0.0
.text 981332 981452 120 0.0
window-app BRD4161A (read/write) 1079428 1079532 104 0.0
.bss 134532 134532 0 0.0
.data 2076 2076 0 0.0
.text 942800 942904 104 0.0
esp32 all-clusters-app c3devkit (read only) 1021766 1021820 54 0.0
(read/write) 1486130 1486194 64 0.0
.dram0.bss 70088 70088 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216000 216064 64 0.0
.flash.text 1021766 1021820 54 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075515 1075571 56 0.0
(read/write) 488160 488216 56 0.0
.dram0.bss 75608 75608 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246468 56 0.0
.flash.text 1070131 1070187 56 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660328 660360 32 0.0
.bss 69540 69540 0 0.0
.data 1992 1992 0 0.0
.text 582996 583028 32 0.0
lock k32w061+release (read/write) 687308 687308 0 0.0
.bss 70012 70012 0 0.0
.data 2004 2004 0 0.0
.text 609492 609492 0 0.0
linux all-clusters-app debug (read only) 2977953 2978241 288 0.0
(read/write) 155312 155312 0 0.0
.bss 61824 61824 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85160 85160 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 264779 264843 64 0.0
.text 2535202 2535426 224 0.0
all-clusters-minimal-app debug (read only) 2823905 2824177 272 0.0
(read/write) 146984 146984 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77720 77720 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 265675 265739 64 0.0
.text 2382914 2383122 208 0.0
bridge-app debug+rpc (read only) 2324017 2324289 272 0.0
(read/write) 125768 125768 0 0.0
.bss 49088 49088 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67096 67096 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 198184 198248 64 0.0
.text 1963810 1964018 208 0.0
chip-tool debug (read only) 10335705 10335977 272 0.0
(read/write) 630888 630888 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 596472 596472 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 517045 517109 64 0.0
.text 8367444 8367652 208 0.0
chip-tool-ipv6only arm64 (read only) 10072828 10073036 208 0.0
(read/write) 696097 696097 0 0.0
.bss 43073 43073 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 632128 632128 0 0.0
.dynamic 528 528 0 0.0
.got 13672 13672 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 481100 481148 48 0.0
.text 8008404 8008564 160 0.0
lighting-app debug+rpc (read only) 2561761 2562049 288 0.0
(read/write) 129856 129856 0 0.0
.bss 49664 49664 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214000 214064 64 0.0
.text 2177506 2177730 224 0.0
lock-app debug (read only) 2526657 2526929 272 0.0
(read/write) 124808 124808 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69208 69208 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229008 229072 64 0.0
.text 2132194 2132402 208 0.0
ota-provider-app debug (read only) 2330241 2330513 272 0.0
(read/write) 118608 118608 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63192 63192 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 203800 203864 64 0.0
.text 1963378 1963586 208 0.0
ota-requestor-app debug (read only) 2448825 2449113 288 0.0
(read/write) 125544 125544 0 0.0
.bss 50048 50048 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67416 67416 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 207552 207616 64 0.0
.text 2069810 2070034 224 0.0
shell debug (read only) 2564465 2564737 272 0.0
(read/write) 141336 141336 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 228082 228146 64 0.0
.text 2178994 2179202 208 0.0
thermostat-no-ble arm64 (read only) 2604004 2604212 208 0.0
(read/write) 158641 158641 0 0.0
.bss 65441 65441 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83368 83368 0 0.0
.dynamic 528 528 0 0.0
.got 5104 5104 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165740 165788 48 0.0
.text 2197968 2198128 160 0.0
tv-app debug (read only) 3112297 3112569 272 0.0
(read/write) 256960 256960 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 249512 249576 64 0.0
.text 2674530 2674738 208 0.0
tv-casting-app debug (read only) 5365833 5366121 288 0.0
(read/write) 158264 158264 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98288 98288 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 333601 333665 64 0.0
.text 4765874 4766098 224 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448688 2448808 120 0.0
.bss 213948 213948 0 0.0
.data 5872 5872 0 0.0
.text 1411332 1411452 120 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176151 116 0.0
bss 142908 142908 0 0.0
rodata 142204 142256 52 0.0
text 812024 812084 60 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156219 120 0.0
bss 142144 142144 0 0.0
rodata 133748 133804 56 0.0
text 801336 801396 60 0.0
p6 all-clusters-app default (read only) 882128 882128 0 0.0
(read/write) 1685700 1685820 120 0.0
.bss 148568 148568 0 0.0
.data 2648 2648 0 0.0
.text 1526096 1526216 120 0.0
all-clusters-minimal-app default (read only) 882848 882848 0 0.0
(read/write) 1629828 1629932 104 0.0
.bss 147848 147848 0 0.0
.data 2648 2648 0 0.0
.text 1470944 1471048 104 0.0
light-app default (read only) 891152 891152 0 0.0
(read/write) 1549828 1549940 112 0.0
.bss 139752 139752 0 0.0
.data 2440 2440 0 0.0
.text 1399248 1399360 112 0.0
lock-app default (read only) 886680 886680 0 0.0
(read/write) 1587420 1587548 128 0.0
.bss 144208 144208 0 0.0
.data 2456 2456 0 0.0
.text 1432368 1432496 128 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798388 798496 108 0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 566528 566578 50 0.0
lighting-app tlsr9518adk80d (read/write) 818436 818544 108 0.0
bss 71428 71428 0 0.0
noinit 40416 40416 0 0.0
text 583072 583124 52 0.0

@woody-apple woody-apple enabled auto-merge (squash) July 20, 2022 23:30
bzbarsky-apple
bzbarsky-apple approved these changes Jul 21, 2022
View reviewed changes
src/app/OperationalDeviceProxy.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 21, 2022 •
edited
Loading

PR #21019: Size comparison from 4a56906 to 4a95a1d

Increases (5 builds for esp32, mbed, nrfconnect)
platform target config section 4a56906 4a95a1d change % change
esp32 all-clusters-app c3devkit (read/write) 1486130 1486194 64 0.0
.flash.rodata 216000 216064 64 0.0
m5stack (read only) 1075515 1075519 4 0.0
(read/write) 488160 488216 56 0.0
.flash.rodata 246412 246468 56 0.0
.flash.text 1070131 1070135 4 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2448688 2448872 184 0.0
.text 1411332 1411516 184 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176123 88 0.0
rodata 142204 142260 56 0.0
text 812024 812052 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156187 88 0.0
rodata 133748 133804 56 0.0
text 801336 801368 32 0.0
Decreases (1 build for esp32)
platform target config section 4a56906 4a95a1d change % change
esp32 all-clusters-app c3devkit (read only) 1021766 1021722 -44 -0.0
.flash.text 1021766 1021722 -44 -0.0
Full report (5 builds for esp32, mbed, nrfconnect)
platform target config section 4a56906 4a95a1d change % change
esp32 all-clusters-app c3devkit (read only) 1021766 1021722 -44 -0.0
(read/write) 1486130 1486194 64 0.0
.dram0.bss 70088 70088 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216000 216064 64 0.0
.flash.text 1021766 1021722 -44 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075515 1075519 4 0.0
(read/write) 488160 488216 56 0.0
.dram0.bss 75608 75608 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246468 56 0.0
.flash.text 1070131 1070135 4 0.0
.iram0.text 123267 123267 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448688 2448872 184 0.0
.bss 213948 213948 0 0.0
.data 5872 5872 0 0.0
.text 1411332 1411516 184 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176123 88 0.0
bss 142908 142908 0 0.0
rodata 142204 142260 56 0.0
text 812024 812052 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156187 88 0.0
bss 142144 142144 0 0.0
rodata 133748 133804 56 0.0
text 801336 801368 32 0.0

@github-actions
Copy link

github-actions bot commented Jul 21, 2022 •
edited
Loading

PR #21019: Size comparison from 6d54807 to 0d57958

Increases (25 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6d54807 0d57958 change % change
bl602 lighting-app bl602 (read/write) 1380914 1380978 64 0.0
.text 1051032 1051060 28 0.0
bl602+rpc (read/write) 1426322 1426386 64 0.0
.text 1082688 1082716 28 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 653839 653911 72 0.0
.rodata 101183 101223 40 0.0
.text 552176 552208 32 0.0
pump-app LP_CC2652R7 (read only) 680579 680699 120 0.0
.rodata 88811 88867 56 0.1
.text 591284 591348 64 0.0
pump-controller-app LP_CC2652R7 (read only) 666355 666475 120 0.0
.rodata 84667 84731 64 0.1
.text 581208 581264 56 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585430 585486 56 0.0
.app_xip_area 464668 464724 56 0.0
efr32 lighting-app BRD4161A (read/write) 1086760 1086864 104 0.0
.text 951472 951576 104 0.0
BRD4161A+rpc (read/write) 1141036 1141156 120 0.0
.text 988860 988980 120 0.0
BRD4161A+rs911x (read/write) 972876 973004 128 0.0
.text 809136 809264 128 0.0
lock-app BRD4161A+wf200 (read/write) 1128248 1128376 128 0.0
.text 981860 981988 128 0.0
window-app BRD4161A (read/write) 1080236 1080356 120 0.0
.text 943448 943568 120 0.0
esp32 all-clusters-app c3devkit (read only) 1021960 1022012 52 0.0
(read/write) 1486298 1486362 64 0.0
.flash.rodata 216008 216072 64 0.0
.flash.text 1021960 1022012 52 0.0
m5stack (read only) 1075743 1075803 60 0.0
(read/write) 488320 488368 48 0.0
.flash.rodata 246412 246460 48 0.0
.flash.text 1070359 1070419 60 0.0
k32w light k32w061+release (read/write) 660784 660800 16 0.0
.text 583324 583340 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9774108 9774316 208 0.0
.rodata 457340 457388 48 0.0
.text 7732372 7732532 160 0.0
thermostat-no-ble arm64 (read only) 2341508 2341716 208 0.0
.rodata 139420 139468 48 0.0
.text 1965280 1965440 160 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2449032 2449152 120 0.0
.text 1411676 1411796 120 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176383 1176503 120 0.0
rodata 142200 142256 56 0.0
text 812248 812308 60 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156447 1156567 120 0.0
rodata 133744 133800 56 0.0
text 801564 801624 60 0.0
p6 all-clusters-app default (read/write) 1686652 1686772 120 0.0
.text 1526536 1526656 120 0.0
all-clusters-minimal-app default (read/write) 1630780 1630900 120 0.0
.text 1471384 1471504 120 0.0
light-app default (read/write) 1551004 1551116 112 0.0
.text 1399912 1400024 112 0.0
lock-app default (read/write) 1588596 1588708 112 0.0
.text 1433032 1433144 112 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798860 798960 100 0.0
text 566826 566876 50 0.0
lighting-app tlsr9518adk80d (read/write) 818908 819008 100 0.0
text 583370 583420 50 0.0
Decreases (5 builds for cc13x2_26x2, cyw30739)
platform target config section 6d54807 0d57958 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 633943 633935 -8 -0.0
.text 556068 556060 -8 -0.0
lock-mtd LP_CC2652R7 (read/write) 183368 183296 -72 -0.0
pump-app LP_CC2652R7 (read/write) 161796 161676 -120 -0.1
pump-controller-app LP_CC2652R7 (read/write) 176140 176020 -120 -0.1
cyw30739 lock cyw930739m2evb_01 (read/write) 587966 587958 -8 -0.0
.app_xip_area 461628 461620 -8 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6d54807 0d57958 change % change
bl602 lighting-app bl602 (read/write) 1380914 1380978 64 0.0
.bss 117482 117482 0 0.0
.data 4480 4480 0 0.0
.text 1051032 1051060 28 0.0
bl602+rpc (read/write) 1426322 1426386 64 0.0
.bss 124930 124930 0 0.0
.data 4600 4600 0 0.0
.text 1082688 1082716 28 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668327 668327 0 0.0
(read/write) 183016 183016 0 0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88311 88311 0 0.0
.text 579700 579700 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633943 633935 -8 -0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 556068 556060 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 671555 671555 0 0.0
(read/write) 169964 169964 0 0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594632 594632 0 0.0
lock-mtd LP_CC2652R7 (read only) 653839 653911 72 0.0
(read/write) 183368 183296 -72 -0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101223 40 0.0
.text 552176 552208 32 0.0
pump-app LP_CC2652R7 (read only) 680579 680699 120 0.0
(read/write) 161796 161676 -120 -0.1
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88867 56 0.1
.text 591284 591348 64 0.0
pump-controller-app LP_CC2652R7 (read only) 666355 666475 120 0.0
(read/write) 176140 176020 -120 -0.1
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84667 84731 64 0.1
.text 581208 581264 56 0.0
shell LP_CC2652R7 (read only) 660810 660810 0 0.0
(read/write) 186036 186036 0 0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85090 0 0.0
.text 575404 575404 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582050 582050 0 0.0
.app_xip_area 460440 460440 0 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587966 587958 -8 -0.0
.app_xip_area 461628 461620 -8 -0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585430 585486 56 0.0
.app_xip_area 464668 464724 56 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1086760 1086864 104 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 951472 951576 104 0.0
BRD4161A+rpc (read/write) 1141036 1141156 120 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 988860 988980 120 0.0
BRD4161A+rs911x (read/write) 972876 973004 128 0.0
.bss 161672 161672 0 0.0
.data 2048 2048 0 0.0
.text 809136 809264 128 0.0
lock-app BRD4161A+wf200 (read/write) 1128248 1128376 128 0.0
.bss 144312 144312 0 0.0
.data 2056 2056 0 0.0
.text 981860 981988 128 0.0
window-app BRD4161A (read/write) 1080236 1080356 120 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 943448 943568 120 0.0
esp32 all-clusters-app c3devkit (read only) 1021960 1022012 52 0.0
(read/write) 1486298 1486362 64 0.0
.dram0.bss 70248 70248 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216008 216072 64 0.0
.flash.text 1021960 1022012 52 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075743 1075803 60 0.0
(read/write) 488320 488368 48 0.0
.dram0.bss 75768 75768 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246460 48 0.0
.flash.text 1070359 1070419 60 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660784 660800 16 0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583324 583340 16 0.0
lock k32w061+release (read/write) 687788 687788 0 0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609844 609844 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9774108 9774316 208 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457340 457388 48 0.0
.text 7732372 7732532 160 0.0
thermostat-no-ble arm64 (read only) 2341508 2341716 208 0.0
(read/write) 141297 141297 0 0.0
.bss 55265 55265 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75616 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139420 139468 48 0.0
.text 1965280 1965440 160 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449032 2449152 120 0.0
.bss 214460 214460 0 0.0
.data 5872 5872 0 0.0
.text 1411676 1411796 120 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176383 1176503 120 0.0
bss 143068 143068 0 0.0
rodata 142200 142256 56 0.0
text 812248 812308 60 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156447 1156567 120 0.0
bss 142304 142304 0 0.0
rodata 133744 133800 56 0.0
text 801564 801624 60 0.0
p6 all-clusters-app default (read only) 881616 881616 0 0.0
(read/write) 1686652 1686772 120 0.0
.bss 149080 149080 0 0.0
.data 2648 2648 0 0.0
.text 1526536 1526656 120 0.0
all-clusters-minimal-app default (read only) 882336 882336 0 0.0
(read/write) 1630780 1630900 120 0.0
.bss 148360 148360 0 0.0
.data 2648 2648 0 0.0
.text 1471384 1471504 120 0.0
light-app default (read only) 890640 890640 0 0.0
(read/write) 1551004 1551116 112 0.0
.bss 140264 140264 0 0.0
.data 2440 2440 0 0.0
.text 1399912 1400024 112 0.0
lock-app default (read only) 886168 886168 0 0.0
(read/write) 1588596 1588708 112 0.0
.bss 144720 144720 0 0.0
.data 2456 2456 0 0.0
.text 1433032 1433144 112 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798860 798960 100 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 566826 566876 50 0.0
lighting-app tlsr9518adk80d (read/write) 818908 819008 100 0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583370 583420 50 0.0

mrjerryjohns
mrjerryjohns previously requested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@mrjerryjohns mrjerryjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use more consistent and complete logging format as already defined in this file.

@andy31415 andy31415 force-pushed the logs_in_operational_device_proxy branch from 0d57958 to 4ab8eb8 Compare July 21, 2022 19:08
@andy31415 andy31415 requested a review from mrjerryjohns July 21, 2022 19:09
@github-actions
Copy link

github-actions bot commented Jul 21, 2022 •
edited
Loading

PR #21019: Size comparison from 1d88b32 to 4ab8eb8

Increases (40 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1d88b32 4ab8eb8 change % change
bl602 lighting-app bl602 (read/write) 1380794 1380802 8 0.0
bl602+rpc (read/write) 1426202 1426210 8 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668327 668375 48 0.0
.rodata 88311 88343 32 0.0
.text 579700 579716 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633935 633991 56 0.0
.rodata 77551 77583 32 0.0
.text 556060 556084 24 0.0
lock-ftd LP_CC2652R7 (read only) 671555 671603 48 0.0
.rodata 76443 76475 32 0.0
.text 594632 594648 16 0.0
lock-mtd LP_CC2652R7 (read only) 653839 653863 24 0.0
.rodata 101183 101191 8 0.0
.text 552176 552192 16 0.0
pump-app LP_CC2652R7 (read only) 680579 680811 232 0.0
.rodata 88811 88979 168 0.2
.text 591284 591348 64 0.0
pump-controller-app LP_CC2652R7 (read only) 666355 666587 232 0.0
.rodata 84667 84843 176 0.2
.text 581208 581264 56 0.0
shell LP_CC2652R7 (read only) 660810 660858 48 0.0
.rodata 85090 85122 32 0.0
.text 575404 575420 16 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585430 585678 248 0.0
.app_xip_area 464668 464916 248 0.1
efr32 lighting-app BRD4161A (read/write) 1086760 1086976 216 0.0
.text 951472 951688 216 0.0
BRD4161A+rpc (read/write) 1141036 1141268 232 0.0
.text 988860 989092 232 0.0
BRD4161A+rs911x (read/write) 972716 972940 224 0.0
.text 808984 809208 224 0.0
lock-app BRD4161A+wf200 (read/write) 1128224 1128464 240 0.0
.text 981844 982084 240 0.0
window-app BRD4161A (read/write) 1080236 1080468 232 0.0
.text 943448 943680 232 0.0
esp32 all-clusters-app c3devkit (read only) 1021930 1021972 42 0.0
(read/write) 1486282 1486458 176 0.0
.flash.rodata 216008 216184 176 0.1
.flash.text 1021930 1021972 42 0.0
m5stack (read only) 1075691 1075751 60 0.0
(read/write) 488304 488456 152 0.0
.flash.rodata 246412 246564 152 0.1
.flash.text 1070307 1070367 60 0.0
k32w lock k32w061+release (read/write) 687788 687836 48 0.0
.text 609844 609892 48 0.0
linux all-clusters-app debug (read only) 2981121 2981761 640 0.0
.rodata 265707 265867 160 0.1
.text 2537298 2537778 480 0.0
all-clusters-minimal-app debug (read only) 2827073 2827713 640 0.0
.rodata 266603 266763 160 0.1
.text 2385010 2385490 480 0.0
bridge-app debug+rpc (read only) 2341705 2342345 640 0.0
.rodata 199208 199368 160 0.1
.text 1980210 1980690 480 0.0
chip-tool debug (read only) 10350497 10351169 672 0.0
.rodata 521525 521717 192 0.0
.text 8375380 8375860 480 0.0
chip-tool-ipv6only arm64 (read only) 9774108 9774572 464 0.0
.rodata 457340 457484 144 0.0
.text 7732372 7732692 320 0.0
lighting-app debug+rpc (read only) 2564897 2565569 672 0.0
.rodata 214896 215088 192 0.1
.text 2179602 2180082 480 0.0
lock-app debug (read only) 2529921 2530561 640 0.0
.rodata 229936 230096 160 0.1
.text 2134386 2134866 480 0.0
ota-provider-app debug (read only) 2333505 2334177 672 0.0
.rodata 204728 204920 192 0.1
.text 1965570 1966050 480 0.0
ota-requestor-app debug (read only) 2451961 2452633 672 0.0
.rodata 208448 208640 192 0.1
.text 2071906 2072386 480 0.0
shell debug (read only) 2567729 2568369 640 0.0
.rodata 229010 229170 160 0.1
.text 2181186 2181666 480 0.0
thermostat-no-ble arm64 (read only) 2341476 2341956 480 0.0
.rodata 139420 139580 160 0.1
.text 1965248 1965568 320 0.0
tv-app debug (read only) 3115497 3116137 640 0.0
.rodata 250408 250568 160 0.1
.text 2676690 2677170 480 0.0
tv-casting-app debug (read only) 5369113 5369753 640 0.0
.rodata 334561 334721 160 0.0
.text 4768050 4768530 480 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2449032 2449264 232 0.0
.text 1411676 1411908 232 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176383 1176603 220 0.0
rodata 142200 142356 156 0.1
text 812248 812308 60 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156447 1156671 224 0.0
rodata 133744 133904 160 0.1
text 801564 801624 60 0.0
p6 all-clusters-app default (read/write) 1686428 1686644 216 0.0
.text 1526328 1526544 216 0.0
all-clusters-minimal-app default (read/write) 1630540 1630772 232 0.0
.text 1471160 1471392 232 0.0
light-app default (read/write) 1550780 1551020 240 0.0
.text 1399704 1399944 240 0.0
lock-app default (read/write) 1588372 1588612 240 0.0
.text 1432824 1433064 240 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798852 799048 196 0.0
text 566822 566864 42 0.0
lighting-app tlsr9518adk80d (read/write) 818908 819096 188 0.0
text 583370 583408 38 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 1d88b32 4ab8eb8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183016 182968 -48 -0.0
lock-ftd LP_CC2652R7 (read/write) 169964 169916 -48 -0.0
lock-mtd LP_CC2652R7 (read/write) 183368 183344 -24 -0.0
pump-app LP_CC2652R7 (read/write) 161796 161564 -232 -0.1
pump-controller-app LP_CC2652R7 (read/write) 176140 175908 -232 -0.1
shell LP_CC2652R7 (read/write) 186036 185988 -48 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1d88b32 4ab8eb8 change % change
bl602 lighting-app bl602 (read/write) 1380794 1380802 8 0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050932 1050932 0 0.0
bl602+rpc (read/write) 1426202 1426210 8 0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082588 1082588 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668327 668375 48 0.0
(read/write) 183016 182968 -48 -0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88311 88343 32 0.0
.text 579700 579716 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633935 633991 56 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77583 32 0.0
.text 556060 556084 24 0.0
lock-ftd LP_CC2652R7 (read only) 671555 671603 48 0.0
(read/write) 169964 169916 -48 -0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76475 32 0.0
.text 594632 594648 16 0.0
lock-mtd LP_CC2652R7 (read only) 653839 653863 24 0.0
(read/write) 183368 183344 -24 -0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101191 8 0.0
.text 552176 552192 16 0.0
pump-app LP_CC2652R7 (read only) 680579 680811 232 0.0
(read/write) 161796 161564 -232 -0.1
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88979 168 0.2
.text 591284 591348 64 0.0
pump-controller-app LP_CC2652R7 (read only) 666355 666587 232 0.0
(read/write) 176140 175908 -232 -0.1
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84667 84843 176 0.2
.text 581208 581264 56 0.0
shell LP_CC2652R7 (read only) 660810 660858 48 0.0
(read/write) 186036 185988 -48 -0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85122 32 0.0
.text 575404 575420 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582050 582050 0 0.0
.app_xip_area 460440 460440 0 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587966 587966 0 0.0
.app_xip_area 461628 461628 0 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585430 585678 248 0.0
.app_xip_area 464668 464916 248 0.1
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1086760 1086976 216 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 951472 951688 216 0.0
BRD4161A+rpc (read/write) 1141036 1141268 232 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 988860 989092 232 0.0
BRD4161A+rs911x (read/write) 972716 972940 224 0.0
.bss 161664 161664 0 0.0
.data 2048 2048 0 0.0
.text 808984 809208 224 0.0
lock-app BRD4161A+wf200 (read/write) 1128224 1128464 240 0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 981844 982084 240 0.0
window-app BRD4161A (read/write) 1080236 1080468 232 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 943448 943680 232 0.0
esp32 all-clusters-app c3devkit (read only) 1021930 1021972 42 0.0
(read/write) 1486282 1486458 176 0.0
.dram0.bss 70232 70232 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216008 216184 176 0.1
.flash.text 1021930 1021972 42 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075691 1075751 60 0.0
(read/write) 488304 488456 152 0.0
.dram0.bss 75752 75752 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246564 152 0.1
.flash.text 1070307 1070367 60 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660784 660784 0 0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583324 583324 0 0.0
lock k32w061+release (read/write) 687788 687836 48 0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609844 609892 48 0.0
linux all-clusters-app debug (read only) 2981121 2981761 640 0.0
(read/write) 155344 155344 0 0.0
.bss 61792 61792 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85224 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 265707 265867 160 0.1
.text 2537298 2537778 480 0.0
all-clusters-minimal-app debug (read only) 2827073 2827713 640 0.0
(read/write) 147016 147016 0 0.0
.bss 60992 60992 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77784 77784 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 266603 266763 160 0.1
.text 2385010 2385490 480 0.0
bridge-app debug+rpc (read only) 2341705 2342345 640 0.0
(read/write) 126920 126920 0 0.0
.bss 50080 50080 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 199208 199368 160 0.1
.text 1980210 1980690 480 0.0
chip-tool debug (read only) 10350497 10351169 672 0.0
(read/write) 631912 631912 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 597480 597480 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 521525 521717 192 0.0
.text 8375380 8375860 480 0.0
chip-tool-ipv6only arm64 (read only) 9774108 9774572 464 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457340 457484 144 0.0
.text 7732372 7732692 320 0.0
lighting-app debug+rpc (read only) 2564897 2565569 672 0.0
(read/write) 129888 129888 0 0.0
.bss 49632 49632 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72296 72296 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214896 215088 192 0.1
.text 2179602 2180082 480 0.0
lock-app debug (read only) 2529921 2530561 640 0.0
(read/write) 124872 124872 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69272 69272 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229936 230096 160 0.1
.text 2134386 2134866 480 0.0
ota-provider-app debug (read only) 2333505 2334177 672 0.0
(read/write) 118672 118672 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63256 63256 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 204728 204920 192 0.1
.text 1965570 1966050 480 0.0
ota-requestor-app debug (read only) 2451961 2452633 672 0.0
(read/write) 125576 125576 0 0.0
.bss 50016 50016 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67480 67480 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 208448 208640 192 0.1
.text 2071906 2072386 480 0.0
shell debug (read only) 2567729 2568369 640 0.0
(read/write) 141400 141400 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76856 76856 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229010 229170 160 0.1
.text 2181186 2181666 480 0.0
thermostat-no-ble arm64 (read only) 2341476 2341956 480 0.0
(read/write) 141265 141265 0 0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75616 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139420 139580 160 0.1
.text 1965248 1965568 320 0.0
tv-app debug (read only) 3115497 3116137 640 0.0
(read/write) 257024 257024 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78792 78792 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 250408 250568 160 0.1
.text 2676690 2677170 480 0.0
tv-casting-app debug (read only) 5369113 5369753 640 0.0
(read/write) 158328 158328 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98352 98352 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 334561 334721 160 0.0
.text 4768050 4768530 480 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449032 2449264 232 0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411676 1411908 232 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176383 1176603 220 0.0
bss 143068 143068 0 0.0
rodata 142200 142356 156 0.1
text 812248 812308 60 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156447 1156671 224 0.0
bss 142304 142304 0 0.0
rodata 133744 133904 160 0.1
text 801564 801624 60 0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686428 1686644 216 0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526328 1526544 216 0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630540 1630772 232 0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471160 1471392 232 0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550780 1551020 240 0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399704 1399944 240 0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588372 1588612 240 0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1432824 1433064 240 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798852 799048 196 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 566822 566864 42 0.0
lighting-app tlsr9518adk80d (read/write) 818908 819096 188 0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583370 583408 38 0.0

@andy31415 andy31415 dismissed mrjerryjohns’s stale review July 22, 2022 14:49

I updated the logs to what was requested.

@woody-apple woody-apple merged commit a671405 into project-chip:master Jul 22, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@andy31415 @isiu-apple
Add nodeid to logs in OperationalDeviceProxy.cpp (project-chip#21019)
b89c8b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logging in OperationalDeviceProxy should include at least the node id
5 participants
@andy31415 @mrjerryjohns @woody-apple @bzbarsky-apple @Damian-Nordic