Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zephyr] Do not initialize real time clock #20490

Merged
merged 1 commit into from
Jul 8, 2022
Merged

[zephyr] Do not initialize real time clock #20490

merged 1 commit into from
Jul 8, 2022

Conversation

Damian-Nordic
Copy link
Contributor

Problem

When there was no support for Last Known UTC Time in the common code we added a similar but incomplete solution to the Zephyr platform code that initializes the real time clock to the firmware build time.

That solution is incorrect as it doesn't allow for updating the Last Known UTC Time, so we should rather return an error if no time synchronization is in place.

Change overview

By default, do not initialize real time clock and use common Last Known UTC Time mechanism to validate operational certificates.

Testing

Verified that the commissioning passes and logs inform about using Last Known UTC Time during CASE.

@Damian-Nordic
[zephyr] Do not initialize real time clock
f836876 
When there was no support for Last Known UTC Time in the
common code we added a similar but incomplete solution
to the Zephyr platform code that initializes the real time
clock to the firmware build time.

That solution is incorrect as it doesn't allow for updating
the Last Known UTC Time, so we should rather return an error
if no time synchronization is in place.

Signed-off-by: Damian Krolik <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 8, 2022 •
edited
Loading

PR #20490: Size comparison from fb98787 to f836876

Increases (3 builds for cc13x2_26x2, telink)
platform target config section fb98787 f836876 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 617951 617959 8 0.0
.text 541376 541384 8 0.0
shell LP_CC2652R7 (read only) 658142 658150 8 0.0
.text 572980 572988 8 0.0
telink light-switch-app tlsr9518adk80d text 565132 565134 2 0.0
Decreases (13 builds for cc13x2_26x2, nrfconnect, telink)
platform target config section fb98787 f836876 change % change
cc13x2_26x2 shell LP_CC2652R7 (read/write) 188584 188576 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174495 1174471 -24 -0.0
text 810916 810912 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154683 -8 -0.0
text 800360 800356 -4 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1165935 1165927 -8 -0.0
text 818880 818872 -8 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1136223 1136215 -8 -0.0
nrf52840dongle_nrf52840 (read/write) 1072507 1072499 -8 -0.0
text 746920 746916 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1069490 1069482 -8 -0.0
text 731428 731424 -4 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1126719 1126695 -24 -0.0
text 770884 770880 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1030398 1030390 -8 -0.0
text 683488 683484 -4 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1078947 1078939 -8 -0.0
text 748632 748628 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1066931 1066923 -8 -0.0
text 739960 739956 -4 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 796636 796628 -8 -0.0
lighting-app tlsr9518adk80d (read/write) 816464 816452 -12 -0.0
Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fb98787 f836876 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665651 665651 0 0.0
(read/write) 185572 185572 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577268 577268 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631443 631443 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 553812 553812 0 0.0
lock-ftd LP_CC2652R7 (read only) 668551 668551 0 0.0
(read/write) 172816 172816 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 591864 591864 0 0.0
lock-mtd LP_CC2652R7 (read only) 617951 617959 8 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541376 541384 8 0.0
pump-app LP_CC2652R7 (read only) 677703 677703 0 0.0
(read/write) 164512 164512 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 588788 588788 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663527 663527 0 0.0
(read/write) 178808 178808 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 578752 578752 0 0.0
shell LP_CC2652R7 (read only) 658142 658150 8 0.0
(read/write) 188584 188576 -8 -0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572980 572988 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579134 579134 0 0.0
.app_xip_area 457904 457904 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585070 585070 0 0.0
.app_xip_area 459104 459104 0 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582206 582206 0 0.0
.app_xip_area 461824 461824 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080652 1080652 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945588 945588 0 0.0
BRD4161A+rpc (read only) 983040 983040 0 0.0
(read/write) 151948 151948 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983032 983032 0 0.0
BRD4161A+rs911x (read/write) 947172 947172 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 804336 804336 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128312 1128312 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 982044 982044 0 0.0
window-app BRD4161A (read/write) 1074436 1074436 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937868 937868 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019500 1019500 0 0.0
(read/write) 1485458 1485458 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215344 215344 0 0.0
.flash.text 1019500 1019500 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073435 1073435 0 0.0
(read/write) 487536 487536 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245796 245796 0 0.0
.flash.text 1068051 1068051 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658192 658192 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 580884 0 0.0
lock k32w061+release (read/write) 684964 684964 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607180 607180 0 0.0
linux all-clusters-app debug (read only) 2957793 2957793 0 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263549 263549 0 0.0
.text 2517058 2517058 0 0.0
all-clusters-minimal-app debug (read only) 2810337 2810337 0 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 265245 265245 0 0.0
.text 2370082 2370082 0 0.0
bridge-app debug+rpc (read only) 2312761 2312761 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1953074 1953074 0 0.0
chip-tool debug (read only) 10296409 10296409 0 0.0
(read/write) 621312 621312 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 586944 586944 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 514197 514197 0 0.0
.text 8352756 8352756 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9989956 9989956 0 0.0
(read/write) 683569 683569 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 622480 622480 0 0.0
.dynamic 528 528 0 0.0
.got 13512 13512 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 476340 476340 0 0.0
.text 7955268 7955268 0 0.0
lighting-app debug+rpc (read only) 2548249 2548249 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213608 213608 0 0.0
.text 2164674 2164674 0 0.0
lock-app debug (read only) 2512865 2512865 0 0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228648 228648 0 0.0
.text 2119074 2119074 0 0.0
ota-provider-app debug (read only) 2319585 2319585 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1953394 1953394 0 0.0
ota-requestor-app debug (read only) 2436737 2436737 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207232 207232 0 0.0
.text 2058354 2058354 0 0.0
shell debug (read only) 2548121 2548121 0 0.0
(read/write) 141096 141096 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227666 227666 0 0.0
.text 2163378 2163378 0 0.0
thermostat-no-ble arm64 (read only) 2592644 2592644 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187520 2187520 0 0.0
tv-app debug (read only) 3099633 3099633 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248928 248928 0 0.0
.text 2662802 2662802 0 0.0
tv-casting-app debug (read only) 5562817 5562817 0 0.0
(read/write) 161968 161968 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343209 343209 0 0.0
.text 4941746 4941746 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447488 2447488 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410132 1410132 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174495 1174471 -24 -0.0
bss 142900 142900 0 0.0
rodata 141776 141776 0 0.0
text 810916 810912 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154683 -8 -0.0
bss 142136 142136 0 0.0
rodata 133308 133308 0 0.0
text 800360 800356 -4 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1165935 1165927 -8 -0.0
bss 144463 144463 0 0.0
rodata 123752 123752 0 0.0
text 818880 818872 -8 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1136223 1136215 -8 -0.0
bss 144892 144892 0 0.0
rodata 115224 115224 0 0.0
text 796872 796872 0 0.0
nrf52840dongle_nrf52840 (read/write) 1072507 1072499 -8 -0.0
bss 151694 151694 0 0.0
rodata 92772 92772 0 0.0
text 746920 746916 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1069490 1069482 -8 -0.0
bss 140834 140834 0 0.0
rodata 116168 116168 0 0.0
text 731428 731424 -4 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1126719 1126695 -24 -0.0
bss 135431 135431 0 0.0
rodata 141592 141592 0 0.0
text 770884 770880 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1030398 1030390 -8 -0.0
bss 131834 131834 0 0.0
rodata 134068 134068 0 0.0
text 683488 683484 -4 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1078947 1078939 -8 -0.0
bss 134358 134358 0 0.0
rodata 117132 117132 0 0.0
text 748632 748628 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1066931 1066923 -8 -0.0
bss 134153 134153 0 0.0
rodata 113916 113916 0 0.0
text 739960 739956 -4 -0.0
p6 all-clusters-app default (read/write) 2564576 2564576 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1522840 1522840 0 0.0
all-clusters-minimal-app default (read/write) 2509632 2509632 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467896 1467896 0 0.0
light-app default (read/write) 2439928 2439928 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1398192 1398192 0 0.0
lock-app default (read/write) 2467160 2467160 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1425424 1425424 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796636 796628 -8 -0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565132 565134 2 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816452 -12 -0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581456 581456 0 0.0

woody-apple
woody-apple approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking platform changes

@woody-apple woody-apple enabled auto-merge (squash) July 8, 2022 16:11
@woody-apple woody-apple merged commit 8b06e80 into project-chip:master Jul 8, 2022
github-actions bot pushed a commit that referenced this pull request Jul 8, 2022
@Damian-Nordic @web-flow
[zephyr] Do not initialize real time clock (#20490)
d2072a5 
When there was no support for Last Known UTC Time in the
common code we added a similar but incomplete solution
to the Zephyr platform code that initializes the real time
clock to the firmware build time.

That solution is incorrect as it doesn't allow for updating
the Last Known UTC Time, so we should rather return an error
if no time synchronization is in place.

Signed-off-by: Damian Krolik <[email protected]>
andy31415 pushed a commit that referenced this pull request Jul 9, 2022
@woody-apple @Damian-Nordic
[zephyr] Do not initialize real time clock (#20490) (#20505)
6874156 
When there was no support for Last Known UTC Time in the
common code we added a similar but incomplete solution
to the Zephyr platform code that initializes the real time
clock to the firmware build time.

That solution is incorrect as it doesn't allow for updating
the Last Known UTC Time, so we should rather return an error
if no time synchronization is in place.

Signed-off-by: Damian Krolik <[email protected]>

Co-authored-by: Damian Królik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
config fast track platform review - pending scripts zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Damian-Nordic @woody-apple