-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes chef tool crashing (#20421) without -r flag. #20436
Merged
andy31415
merged 1 commit into
project-chip:master
from
Cascoda:bug-20421-chef-rpc-option
Jul 7, 2022
Merged
Fixes chef tool crashing (#20421) without -r flag. #20436
andy31415
merged 1 commit into
project-chip:master
from
Cascoda:bug-20421-chef-rpc-option
Jul 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
Jul 7, 2022
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
msandstedt,
saurabhst,
selissia and
tecimovic
July 7, 2022 15:44
pullapprove
bot
requested review from
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
July 7, 2022 15:44
PR #20436: Size comparison from acbe9cd to 4bff888 Increases (3 builds for cc13x2_26x2, telink)
Decreases (2 builds for esp32, mbed)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 7, 2022
woody-apple
added a commit
that referenced
this pull request
Jul 7, 2022
Co-authored-by: Richard Wells <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Prevent a
None
value for the -r option being converted to int and crashing. Instead it is converted to either "1" or "0".Testing